Skip to content

Allow overriding CLI run arg type #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 17, 2022
Merged

Allow overriding CLI run arg type #291

merged 7 commits into from
Jan 17, 2022

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jan 13, 2022

Description

This is useful for secret-operator, which doesn't have a product-config but does care about other options, such as the CSI plugin socket path.

This depends on and builds upon #289.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)

@nightkr nightkr requested a review from a team January 13, 2022 14:42
@nightkr
Copy link
Member Author

nightkr commented Jan 13, 2022

For reviewing only d7c6a12 and newer are relevant, the older commits come from #289.

maltesander
maltesander approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nightkr
Copy link
Member Author

nightkr commented Jan 17, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 17, 2022

Build succeeded:

@bors bors bot merged commit a75c69b into main Jan 17, 2022
@bors bors bot deleted the feature/custom-run-args branch January 17, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nightkr @maltesander