Skip to content

[Merged by Bors] - Add common datastructures shared between the operators #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

sbernauer
Copy link
Member

Description

As decided in Architecture meeting from 06.04.2021.
Copied over from the commons-operator, so the actual struct fields should already be well discussed ;)

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer requested a review from a team April 8, 2022 07:54
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbernauer
Copy link
Member Author

Thanks for your review! Could you please tick the review boxes as i need them to merge?

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 11, 2022
## Description

As decided in Architecture meeting from 06.04.2021.
Copied over from the commons-operator, so the actual struct fields should already be well discussed ;)
@bors
Copy link
Contributor

bors bot commented Apr 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add common datastructures shared between the operators [Merged by Bors] - Add common datastructures shared between the operators Apr 11, 2022
@bors bors bot closed this Apr 11, 2022
@bors bors bot deleted the add-commons branch April 11, 2022 06:45
bors bot pushed a commit to stackabletech/commons-operator that referenced this pull request Apr 19, 2022
## Description

Follow up of stackabletech/operator-rs#366
The commons structs now reside in operator-rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants