[Merged by Bors] - Adapt resource structs to work with struct merging code #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sönke Liebau <[email protected]>
Adds test to check correct handling of selectors when creating pvcs. Signed-off-by: Sönke Liebau <[email protected]>
Signed-off-by: Sönke Liebau <[email protected]>
5 tasks
Clippy Signed-off-by: Sönke Liebau <[email protected]>
Signed-off-by: Sönke Liebau <[email protected]>
nightkr
approved these changes
May 5, 2022
# Conflicts: # CHANGELOG.md
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 5, 2022
## Description This PR makes a few small changes to the resources structs so that they work with the config merging code. Most notably it changes all Atomic values to options and adds the required Derive macros to make the Resources struct mergeable. This might be breaking depending on how downstream code uses the structs. Serialization and Deserialization should not be affected (apart from being more lenient due to values being optional now). If downstream code simply uses the convenience functions on the structs to obtain derived ResourceRequirements and PersistentVolumeClaim objects this shouldn't require any changes as those inferfaces have been kept stable.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a few small changes to the resources structs so that they work with the config merging code.
Most notably it changes all Atomic values to options and adds the required Derive macros to make the Resources struct mergeable.
This might be breaking depending on how downstream code uses the structs. Serialization and Deserialization should not be affected (apart from being more lenient due to values being optional now).
If downstream code simply uses the convenience functions on the structs to obtain derived ResourceRequirements and PersistentVolumeClaim objects this shouldn't require any changes as those inferfaces have been kept stable.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information