Skip to content

[Merged by Bors] - The storage class was not correctly carried over from PVCConfig structs into derived PVC objects. #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

soenkeliebau
Copy link
Member

Description

Fixes #411

Adds copying of storageclass from PVCConfig into derived PVC objects.
Signed-off-by: Sönke Liebau [email protected]

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

The storage class was not correctly carried over from PVCConfig structs into derived PVC objects.

Signed-off-by: Sönke Liebau <[email protected]>
@soenkeliebau soenkeliebau requested a review from a team May 24, 2022 20:45
@soenkeliebau
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request May 25, 2022
…ts into derived PVC objects. (#412)

## Description

Fixes #411

Adds copying of storageclass from PVCConfig into derived PVC objects.
Signed-off-by: Sönke Liebau <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 25, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title The storage class was not correctly carried over from PVCConfig structs into derived PVC objects. [Merged by Bors] - The storage class was not correctly carried over from PVCConfig structs into derived PVC objects. May 25, 2022
@bors bors bot closed this May 25, 2022
@bors bors bot deleted the fix/411-set_storageclass branch May 25, 2022 09:14
soenkeliebau added a commit that referenced this pull request May 25, 2022
bors bot pushed a commit that referenced this pull request May 25, 2022
Signed-off-by: Sönke Liebau <[email protected]>

## Description

Added changelog entry that was forgotten in #412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_pvc() doesn't correctly set the storage class
2 participants