[Merged by Bors] - feat: Improve package name handling in OpaConfig #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leading forward slashes are removed. Dots are converted to forward slashes. This is done in the `document_url` function, therefore the sanitization is done on each call. Introducing a constructor and getters to perform the sanitization at most once would be a breaking change, therefore not considered.
maltesander
approved these changes
Jul 28, 2022
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
## Description Leading forward slashes are removed. Dots are converted to forward slashes. This is done in the `document_url` function, therefore the sanitization is done on each call. Introducing a constructor and getters to perform the sanitization at most once would be a breaking change, therefore not considered.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
2 tasks
nightkr
added a commit
that referenced
this pull request
Aug 1, 2022
bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
## Description *Please add a description here. This will become the commit message of the merge request later.* Co-authored-by: Teo Klestrup Röijezon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Leading forward slashes are removed. Dots are converted to forward slashes.
This is done in the
document_urlfunction, therefore the sanitization isdone on each call. Introducing a constructor and getters to perform the
sanitization at most once would be a breaking change, therefore not considered.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information