Skip to content

[Merged by Bors] - Implement ClusterResource for ServiceAccount and RoleBinding #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 6, 2022

Description

These are currently used by zookeeper-operator, so if we want to be consistent and deploy everything with clusterresources then we'll need to add support for them.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add Secret as well? Will need that for Trino.

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member Author

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Oct 7, 2022
## Description

These are currently used by zookeeper-operator, so if we want to be consistent and deploy everything with clusterresources then we'll need to add support for them.



Co-authored-by: Teo Klestrup Röijezon <[email protected]>
Co-authored-by: maltesander <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 7, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement ClusterResource for ServiceAccount and RoleBinding [Merged by Bors] - Implement ClusterResource for ServiceAccount and RoleBinding Oct 7, 2022
@bors bors bot closed this Oct 7, 2022
@bors bors bot deleted the feature/clusterresources-serviceaccount branch October 7, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants