Skip to content

[Merged by Bors] - Expose memory quantity parser directly #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Nov 7, 2022

Description

This is used by stackabletech/nifi-operator#371.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested a review from a team November 7, 2022 15:52
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is non breaking due to Memory not being public right?

@nightkr
Copy link
Member Author

nightkr commented Nov 7, 2022

Yes.

@maltesander
Copy link
Member

Go for it!

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@nightkr
Copy link
Member Author

nightkr commented Nov 8, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 8, 2022
## Description

This is used by stackabletech/nifi-operator#371.



Co-authored-by: Teo Klestrup Röijezon <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Expose memory quantity parser directly [Merged by Bors] - Expose memory quantity parser directly Nov 8, 2022
@bors bors bot closed this Nov 8, 2022
@bors bors bot deleted the feature/expose-memory-quantity branch November 8, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants