Skip to content

[Merged by Bors] - Added create_log4j_2_config to product logging #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - Added create_log4j_2_config to product logging #540

wants to merge 11 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jan 20, 2023 •
edited by siegfriedweber
Loading

Description

  • Added method to create log4j2 config properties

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander self-assigned this Jan 20, 2023
@maltesander maltesander marked this pull request as ready for review January 23, 2023 07:40
@maltesander maltesander mentioned this pull request Jan 23, 2023
Closed
2 tasks
siegfriedweber
siegfriedweber requested changes Jan 23, 2023
View reviewed changes
siegfriedweber
siegfriedweber approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 23, 2023
@maltesander @siegfriedweber
Added create_log4j_2_config to product logging (#540)
789e66f 
## Description

- Added method to create log4j2 config properties



Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Siegfried Weber <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 23, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Added create_log4j_2_config to product logging [Merged by Bors] - Added create_log4j_2_config to product logging Jan 23, 2023
@bors bors bot closed this Jan 23, 2023
@bors bors bot deleted the add-create-log4j-2-config branch January 23, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@maltesander maltesander

Labels
status/blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltesander @siegfriedweber