Skip to content

Feat: More CRD docs #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 12, 2023
Merged

Feat: More CRD docs #697

merged 12 commits into from
Dec 12, 2023

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 12, 2023

Description

Worked on the S3, Listener, AuthenticationClass docs.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@fhennig fhennig marked this pull request as ready for review December 12, 2023 11:04
@fhennig fhennig requested a review from a team December 12, 2023 11:05
@maltesander maltesander self-requested a review December 12, 2023 13:03
maltesander
maltesander requested changes Dec 12, 2023
View reviewed changes
@fhennig fhennig enabled auto-merge December 12, 2023 13:27
maltesander
maltesander approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fhennig fhennig added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit e800d3c Dec 12, 2023
@fhennig fhennig deleted the feat/more-crd-docs branch December 12, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhennig @maltesander