Skip to content

fix: Let ldap add_volumes_and_mounts also add the needed TLS volumes #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2024
Merged

fix: Let ldap add_volumes_and_mounts also add the needed TLS volumes #708

merged 3 commits into from
Jan 4, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 4, 2024 •
edited by NickLarsenNZ
Loading

Description

Noticed in stackabletech/airflow-operator#366

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer changed the title fix: Let ldap::AuthenticationProvider::add_volumes_and_mounts also ad… fix: Let ldap::AuthenticationProvider::add_volumes_and_mounts also add the needed TLS volumes Jan 4, 2024
@sbernauer sbernauer changed the title fix: Let ldap::AuthenticationProvider::add_volumes_and_mounts also add the needed TLS volumes fix: Let ldap add_volumes_and_mounts also add the needed TLS volumes Jan 4, 2024
fhennig
fhennig approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit 8320525 Jan 4, 2024
@sbernauer sbernauer deleted the fix/ldap-tls-volumes branch January 4, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhennig fhennig fhennig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @fhennig