Add listener volume scope for secret volume builders #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically a CRD change, but it "just" exposes another field of another API consistently with how we expose the rest of it. |
7 tasks
|
I read the linked docs and they are very cryptic to me. Describing a use-case or providing an example would help. |
|
@razvan I created stackabletech/secret-operator#496 for addressing the documentation side. |
sbernauer
approved these changes
Sep 6, 2024
nightkr
added a commit
to stackabletech/kafka-operator
that referenced
this pull request
Sep 9, 2024
github-merge-queue bot
pushed a commit
to stackabletech/kafka-operator
that referenced
this pull request
Oct 7, 2024
…443) * Migrate kafka-operator to use lb-operator for exposing brokers This is far from final (for example, we'd need to expose a configurable LoadBalancerClass, for example), but I wanted to see whether lb-op would be a good fit for this operator first. * regenerated charts * Update for lb-operator -> listener-operator rebrand * Use ListenerOperatorVolumeSourceBuilder * Use shortcut for creating the listener volume * Allow git source for operator-rs temporarily * Rename node_cmd -> node_address_cmd * Remove operator-rs entry in deny.toml * Make listenerclass configurable * Use operator-rs from git * Use listener secret scope * Use listener for bootstrap and discovery * Separate out kcat secret management now that it is the only PEM user * Remove unused KafkaTlsSecurity::kafka * Regenerate CRD * Switch to main op-rs stackabletech/operator-rs#858 was merged * Switch to per-rolegroup bootstrap listeners * make crds * CRD docs * Delete old test files * Documentation * Try to un-angry rustdoc * Re-enable orphan cleanup * Changelog * Fix configuration test * Update docs/modules/kafka/examples/getting_started/kafka.yaml Co-authored-by: Sebastian Bernauer <[email protected]> * Rename TLS volume variables for consistency * Rename volumes/paths too, correspondingly * Remove stale FIXME * Add RBAC permission to delete listeners (orphan clenaup) * Make service_ports return ListenerPorts instead * Recommend using the same ListenerClass across rolegroups * Apply recommended labels to broker listeners * Apply the correct rolegroup to bootstrap listeners, too * Apply the correct rolegroup label to the rolegroup configmaps * Apply recommended labels to the bootstrap listener PVC too * Remove version from persistent PVCs It broke upgrading * Add note about upgrading to changelog * docs: Add note on what bootstrap listeners return * Update futures to 0.3.31 0.3.30 was yanked due to soundness issues. * Drop unused futures compat feature * Reformat bootstrap rolegroup note slightly --------- Co-authored-by: Malte Sander <[email protected]> Co-authored-by: Siegfried Weber <[email protected]> Co-authored-by: Sebastian Bernauer <[email protected]> Co-authored-by: Sebastian Bernauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://docs.stackable.tech/home/stable/secret-operator/scope#listener-volume
Definition of Done Checklist
Author
Reviewer
Acceptance