Skip to content

chore: Dependecy updates, such as kube 0.95.0 and Kubernetes 0.31 #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 18, 2024

Description

I was not able to update opentelemetry, and would let it to the experts to figure it out, CC @Techassi, @NickLarsenNZ and @nightkr

I hope the aws-lc-rs crate will not cause any problems with Nix. I bumped zookeeper-operator and make run-dev worked fine.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@Techassi
Copy link
Member

I hope the aws-lc-rs crate will not cause any problems with Nix. I bumped zookeeper-operator and make run-dev worked fine.

We could evaluate if we can use ring as a crypt backend instead (supported by rustls).

@sbernauer
Copy link
Member Author

We could evaluate if we can use ring as a crypt backend instead (supported by rustls).

I sadly know the situation from trino-lb :/ This PR should not change anything (in comparison to main), and the zookeeper test worked, so I'd call it ready to be merged

@sbernauer sbernauer self-assigned this Sep 19, 2024
NickLarsenNZ
NickLarsenNZ previously approved these changes Sep 19, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two small comments.

@sbernauer sbernauer requested a review from Techassi September 19, 2024 07:25
@sbernauer sbernauer enabled auto-merge September 19, 2024 07:26
@sbernauer sbernauer added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 77293f3 Sep 19, 2024
10 checks passed
@sbernauer sbernauer deleted the chore/bumps-3 branch September 19, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants