Skip to content

fix: PR base branch condition #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Dec 10, 2024

Fixes an error in the workflow condition to determine the base branch of a pull-request.

Tested:

@adwk67 adwk67 marked this pull request as ready for review December 10, 2024 17:08
@adwk67 adwk67 requested a review from NickLarsenNZ December 10, 2024 17:16
NickLarsenNZ
NickLarsenNZ previously approved these changes Dec 10, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some optional suggestions for consistency

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 8e7969c Dec 10, 2024
2 checks passed
@adwk67 adwk67 deleted the fix/workflow-pr-branch-conditions branch December 10, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants