Skip to content

Add Cert-Manager backend #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nightkr opened this issue Jul 19, 2024 · 3 comments · Fixed by #482
Closed

Add Cert-Manager backend #474

nightkr opened this issue Jul 19, 2024 · 3 comments · Fixed by #482
Assignees
@nightkr
Labels
customer-request release/24.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Comments

@nightkr
Copy link
Member

nightkr commented Jul 19, 2024

Builds on #473 by automatically creating the applicable Cert-Manager Certificate objects, and mounting in the applicable certificates.
@nightkr nightkr self-assigned this Jul 23, 2024
@nightkr nightkr moved this to Development: In Progress in Stackable Engineering Jul 23, 2024
nightkr added a commit that referenced this issue Jul 23, 2024
@nightkr
Initial prototype for cert-manager integration
99b2e30 
See #474
@nightkr nightkr mentioned this issue Jul 23, 2024
Merged
@nightkr nightkr mentioned this issue Aug 1, 2024
Open
@nightkr nightkr moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Aug 1, 2024
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 16, 2024
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Sep 16, 2024
@lfrancke
Copy link
Member

Can you please add a link to the documentation as well as a short snippet for the release notes?

And would it be useful to show this off to the team?

nightkr added a commit that referenced this issue Sep 20, 2024
@nightkr @NickLarsenNZ
Add a backend that requests Cert-Manager certificates (#482)
3512603 
* Initial prototype for cert-manager integration

See #474

* Use PVC name as cert-manager secret, rather than pod name

* Move cert-manager integration into a separate backend

* Reorganize

* Cert-Manager: only set node label if volume has node scope

* CRD docs

* Fix CSI always being considered dirty

* Reference docs

* Update cert-manager guide to use cert-manager backend

* Fix rustdoc warnings

* Regenerate CRDs

* Allow overriding Cert-Manager lifetimes

* Changelog

* Make pvc_name optional

* Update rust/operator-binary/src/backend/cert_manager.rs

Co-authored-by: Nick <[email protected]>

* Update rust/operator-binary/src/backend/mod.rs

Co-authored-by: Nick <[email protected]>

* Update rust/operator-binary/src/backend/mod.rs

Co-authored-by: Nick <[email protected]>

* Update tests/templates/kuttl/cert-manager-tls/consumer.yaml

Co-authored-by: Nick <[email protected]>

* Update rust/operator-binary/src/crd.rs

Co-authored-by: Nick <[email protected]>

* Align cert-manager CRDs better with upstream

* Regenerate CRD

* Quote scopes in errors

* Add context for certificate object errors

* Make Clippy happy

* cargo fmt

---------

Co-authored-by: Nick <[email protected]>
@nightkr
Copy link
Member Author

nightkr commented Oct 10, 2024

Docs: https://docs.stackable.tech/home/nightly/secret-operator/cert-manager

Relnote: "The Stackable Data Platform now supports provisioning TLS certificates using cert-manager."

And would it be useful to show this off to the team?

Maybe? Probably worth mentioning that it exists, but as an operator dev it should be transparent.

@lfrancke lfrancke added release-note Denotes a PR that will be considered when it comes time to generate release notes. demo-needed labels Oct 15, 2024
@lfrancke lfrancke moved this from Acceptance: In Progress to Share in Stackable Engineering Oct 15, 2024
@nightkr
Copy link
Member Author

nightkr commented Oct 28, 2024

Demo:
https://github.com/user-attachments/assets/91329cc6-5076-4b2c-8b94-db63a87a621d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nightkr nightkr

Labels
customer-request release/24.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a backend that requests Cert-Manager certificates stackabletech/secret-operator
2 participants
@lfrancke @nightkr