Skip to content

[Merged by Bors] - Make kubelet dir configurable (fixes #229) #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 2, 2023

Description

This should fix #229 from secret-operator's perspective. There are still outstanding issues in zk-op that I'll open a new issue for.

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snap ftw 🚀 ... not ...

@nightkr
Copy link
Member Author

nightkr commented Feb 2, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 2, 2023
# Description

This should fix #229 from secret-operator's perspective. There are still outstanding issues in zk-op that I'll open a new issue for.
@bors
Copy link
Contributor

bors bot commented Feb 2, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make kubelet dir configurable (fixes #229) [Merged by Bors] - Make kubelet dir configurable (fixes #229) Feb 2, 2023
@bors bors bot closed this Feb 2, 2023
@bors bors bot deleted the bugfix/configurable-kubelet-dir branch February 2, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

microk8s kubelet cannot connect to secret-operator node registrar
2 participants