-
-
Notifications
You must be signed in to change notification settings - Fork 7
Rotate AutoTLS CAs #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotate AutoTLS CAs #350
Conversation
It works:tm:, still need to do docs and configuration. |
Not sure how to test this properly, "just let the test wait for two years" obviously isn't a viable strategy. We could at least test certificate selection by setting up some static certificates in the test suite, but having them be completely static wouldn't work either (since the correct certificate to choose depends on the system time). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Tested manually by lowering the constant times and successfully rolled over 👍
Co-authored-by: Sebastian Bernauer <[email protected]>
…-operator into feature/ca-rotation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and seems to work.
I would prefer having kuttl tests for this (#354 might help), as we will probably never run into CA rollovers in our tests, but I can see this being hard...
Created #355 for the testing. |
Description
Fixes #93
Definition of Done Checklist