-
-
Notifications
You must be signed in to change notification settings - Fork 7
Make CA lifetimes configurable #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some docs to this page? https://docs.stackable.tech/home/nightly/secret-operator/secretclass#backend-autotls
maybe the property could be lifetime
instead of caLifetime
since it's under the ca
key already (sorry for the bikeshedding 😬 )
other than that, looks good to me 👍
Added docs, updated to align with the CRD review. |
This doesn't yet reflect the updated default CA duration of one year, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
regarding the 2y default in default_ca_certificate_lifetime
I think it might be easiest to update it in here still. I can re-approve if you sitll want to change this @nightkr
If this change is not made here we need to make a ticket for it so we do not forget about it later
The ticket we discussed in Arch meeting is #358 ;) |
Alright so yeah fine either way, do it here and close #358 too or not 🆗 |
I think either is fine, I'd personally do it in a separate PR and changelog entry. |
…ech/secret-operator into feature/configure-ca-lifetime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error: unresolved link to `Self::ca_lifetime`
--> rust/operator-binary/src/backend/tls/ca.rs:154:28
|
154 | /// and smaller than [`Self::ca_lifetime`].
| ^^^^^^^^^^^^^^^^^ the struct `Config` has no field or associated item named `ca_lifetime`
|
= note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`
error: could not document `stackable-secret-operator`
Argh, you're right. Should be fixed now.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Fixes #354
Definition of Done Checklist