Skip to content

Make RSA key length configurable #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Oct 2, 2024
Merged

Make RSA key length configurable #506

merged 37 commits into from
Oct 2, 2024

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Sep 30, 2024 •
edited
Loading

Description

This is currently just a "pass-through" for the key length. The RSA / Key length structs could be moved into their own submodule, but since the whole part will be reworked with the operator-rs functionality, this was not done here.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@maltesander maltesander self-assigned this Sep 30, 2024
@maltesander maltesander marked this pull request as ready for review September 30, 2024 15:05
sbernauer
sbernauer requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maltesander maltesander requested a review from sbernauer October 1, 2024 08:02
sbernauer
sbernauer requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Techassi
Techassi requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes and questions.

@maltesander
Copy link
Member Author

test https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/secret-operator-it-custom/10/

sbernauer
sbernauer previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maltesander maltesander requested a review from sbernauer October 2, 2024 07:53
sbernauer
sbernauer previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me, but please address @Techassi comments

sbernauer
sbernauer previously approved these changes Oct 2, 2024
View reviewed changes
Techassi
Techassi requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly minor comments.

@maltesander maltesander requested a review from Techassi October 2, 2024 09:57
Techassi
Techassi previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit.

rust/operator-binary/src/crd.rs Outdated
#[serde(rename_all = "camelCase")]
pub enum CertificateKeyGeneration {
Rsa {
/// The amount of bits used for generating the RSA keypair.
Copy link
Member

@Techassi Techassi Oct 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use "key pair".

Suggested change
/// The amount of bits used for generating the RSA keypair.
/// The amount of bits used for generating the RSA key pair.

Beware: This requires a make regenerate-chart

@maltesander maltesander added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 9a23e70 Oct 2, 2024
31 checks passed
@maltesander maltesander deleted the feat/make-tls-key-length-configurable branch October 2, 2024 11:37
@sbernauer sbernauer mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer left review comments

@Techassi Techassi Techassi approved these changes

@nightkr nightkr Awaiting requested review from nightkr

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase RSA key length
3 participants
@maltesander @Techassi @sbernauer