Skip to content

[Merged by Bors] - Enable logging #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 34 commits into from
Closed

[Merged by Bors] - Enable logging #380

wants to merge 34 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Feb 10, 2023 •
edited by siegfriedweber
Loading

Description

fixes #376

TODO

  • Release new operator-rs
  • Adapt cargo.toml to new operator-rs release

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander self-assigned this Feb 10, 2023
@maltesander maltesander mentioned this pull request Feb 10, 2023
Closed
5 tasks
@maltesander
Copy link
Member Author

maltesander commented Feb 13, 2023 •
edited
Loading

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/53/

@maltesander maltesander marked this pull request as ready for review February 13, 2023 10:59
@maltesander
Merge remote-tracking branch 'origin/main' into enable-logging
b30ac77 
# Conflicts:
#	docs/modules/trino/pages/usage_guide/log-aggregation.adoc
#	docs/modules/usage_guide/nav.adoc
@maltesander
added log aggregation to usage guide
6d8f459
siegfriedweber
siegfriedweber requested changes Feb 14, 2023
View reviewed changes
siegfriedweber
siegfriedweber requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The navigation of the documentation must be fixed. Everything else looks good to me.

@maltesander
Copy link
Member Author

maltesander commented Feb 20, 2023 •
edited
Loading

Last test hopefully: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/56/

siegfriedweber
siegfriedweber approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 22, 2023
@maltesander
Enable logging (#380)
14717ac 
# Description

fixes #376

## TODO

- [x] Release new operator-rs
- [x] Adapt cargo.toml to new operator-rs release



Co-authored-by: Malte Sander <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 22, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Enable logging [Merged by Bors] - Enable logging Feb 22, 2023
@bors bors bot closed this Feb 22, 2023
@bors bors bot deleted the enable-logging branch February 22, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Log Aggregation for Trino
2 participants
@maltesander @siegfriedweber