Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

eliminate printf() calls #167

Closed
akruis opened this issue Aug 5, 2018 · 2 comments
Closed

eliminate printf() calls #167

akruis opened this issue Aug 5, 2018 · 2 comments

Comments

@akruis
Copy link

akruis commented Aug 5, 2018

There are two printf(...) calls in Stackless/module/scheduling.c. They are used to emit an error message, if there is a pending error while entering Stackless subsystem. You won't see this message, unless you use the C-API. I noticed the printf() calls while preparing a test for #166. Besides using printf() is a no-go by itself, the rest of the error message - emitted by PyErr_Print() - goes to stderr.

Task: Replace the printf() with PySys_WriteStderr(...).

@akruis akruis self-assigned this Aug 5, 2018
akruis pushed a commit that referenced this issue Aug 5, 2018
printf() was used to emit parts of an error message, if there is a
pending error while entering Stackless subsystem.
@akruis akruis modified the milestones: v3.7.x-slp, v3.6.5-slp Aug 5, 2018
@akruis
Copy link
Author

akruis commented Aug 7, 2018

Ported to master-slp: ef448f3

akruis pushed a commit that referenced this issue Aug 7, 2018
printf() was used to emit parts of an error message, if there is a
pending error while entering Stackless subsystem.
(cherry picked from commit 8a44a5f)
akruis pushed a commit that referenced this issue Aug 7, 2018
printf() was used to emit parts of an error message, if there is a
pending error while entering Stackless subsystem.
(cherry picked from commit 8a44a5f)
akruis pushed a commit that referenced this issue Aug 7, 2018
printf() was used to emit parts of an error message, if there is a
pending error while entering Stackless subsystem.
(cherry picked from commit 8a44a5f)
@akruis
Copy link
Author

akruis commented Aug 16, 2018

Fix ported to 3.6-slp (85dbd4b) and 3.5-slp (bdb96df).

@akruis akruis closed this as completed Aug 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant