Skip to content

Add warnings for PCH error #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Add warnings for PCH error #421

merged 1 commit into from
Aug 5, 2021

Conversation

WardBrian
Copy link
Member

Resolves #382. Based on the same idea in cmdstanr

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

This is a (partial?) solution to #382. It produces a warning if the compile command fails for this reason, which currently directs the user to call install_cmdstan(overwrite=True).

If we believe there is merit to providing a separate rebuild_cmdstan(), I can refactor the install code to support this, but it would be largely the same as this call, I believe.

I should also mention I'm not sure how to artificially recreate this issue to test it, but the logic behind showing the warning is simple enough (based on cmdstanr) that I am pretty positive it would work

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Resolves #382. Based on the same idea in cmdstanr
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #421 (45b1eba) into develop (ea0f3f2) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #421      +/-   ##
===========================================
- Coverage    77.31%   77.24%   -0.08%     
===========================================
  Files           27       27              
  Lines         8556     8568      +12     
===========================================
+ Hits          6615     6618       +3     
- Misses        1941     1950       +9     
Impacted Files Coverage Δ
a/cmdstanpy/cmdstanpy/cmdstanpy/model.py 80.43% <0.00%> (-0.61%) ⬇️
cmdstanpy/cmdstanpy/model.py 79.34% <0.00%> (-0.60%) ⬇️
...runner/work/cmdstanpy/cmdstanpy/cmdstanpy/model.py 79.34% <0.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0f3f2...45b1eba. Read the comment docs.

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mitzimorris mitzimorris merged commit 0c79b50 into develop Aug 5, 2021
@mitzimorris mitzimorris deleted the bugfix/382-pch-header branch August 17, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add rebuild_cmdstan to handle Xcode updates
3 participants