Add warnings for PCH error #421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #382. Based on the same idea in cmdstanr
Submission Checklist
Summary
This is a (partial?) solution to #382. It produces a warning if the compile command fails for this reason, which currently directs the user to call
install_cmdstan(overwrite=True)
.If we believe there is merit to providing a separate
rebuild_cmdstan()
, I can refactor the install code to support this, but it would be largely the same as this call, I believe.I should also mention I'm not sure how to artificially recreate this issue to test it, but the logic behind showing the warning is simple enough (based on cmdstanr) that I am pretty positive it would work
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: