Skip to content

chore_: extract status-im/extkeys #6504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2025
Merged

Conversation

igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Apr 7, 2025

@status-im-auto
Copy link
Member

status-im-auto commented Apr 7, 2025

Jenkins Builds

Click to see older builds (17)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b274af7 #1 2025-04-07 12:06:15 ~3 min android 📦aar
✔️ b274af7 #1 2025-04-07 12:06:26 ~3 min ios 📦zip
✖️ b274af7 #1 2025-04-07 12:07:49 ~4 min tests 📄log
✔️ b274af7 #1 2025-04-07 12:08:19 ~5 min macos 📦zip
✔️ b274af7 #1 2025-04-07 12:08:45 ~5 min macos 📦zip
✔️ b274af7 #1 2025-04-07 12:08:59 ~5 min windows 📦zip
✔️ b274af7 #1 2025-04-07 12:09:07 ~5 min linux 📦zip
✔️ b274af7 #1 2025-04-07 12:12:10 ~8 min tests-rpc 📄log
✔️ b8f232d #2 2025-04-07 12:18:04 ~3 min android 📦aar
✔️ b8f232d #2 2025-04-07 12:18:17 ~3 min ios 📦zip
✔️ b8f232d #2 2025-04-07 12:19:55 ~4 min windows 📦zip
✔️ b8f232d #2 2025-04-07 12:20:11 ~5 min macos 📦zip
✔️ b8f232d #2 2025-04-07 12:20:47 ~5 min linux 📦zip
✔️ b8f232d #2 2025-04-07 12:21:21 ~6 min macos 📦zip
✖️ b8f232d #2 2025-04-07 12:24:12 ~9 min tests-rpc 📄log
✔️ b8f232d #3 2025-04-07 12:43:49 ~8 min tests-rpc 📄log
✔️ b8f232d #2 2025-04-07 12:51:19 ~36 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7f417cd #3 2025-04-14 15:36:04 ~2 min android 📦aar
✔️ 7f417cd #3 2025-04-14 15:36:31 ~3 min ios 📦zip
✔️ 7f417cd #3 2025-04-14 15:38:22 ~5 min macos 📦zip
✔️ 7f417cd #3 2025-04-14 15:38:56 ~5 min linux 📦zip
✔️ 7f417cd #3 2025-04-14 15:39:13 ~5 min windows 📦zip
✔️ 7f417cd #3 2025-04-14 15:39:21 ~5 min macos 📦zip
✔️ 7f417cd #4 2025-04-14 15:41:39 ~8 min tests-rpc 📄log
✖️ 7f417cd #3 2025-04-14 15:56:46 ~23 min tests 📄log
✔️ 267bc60 #4 2025-04-16 15:48:15 ~2 min android 📦aar
✔️ 267bc60 #4 2025-04-16 15:48:42 ~3 min ios 📦zip
✔️ 267bc60 #4 2025-04-16 15:49:51 ~4 min windows 📦zip
✔️ 267bc60 #4 2025-04-16 15:50:33 ~5 min macos 📦zip
✔️ 267bc60 #4 2025-04-16 15:50:57 ~5 min macos 📦zip
✔️ 267bc60 #4 2025-04-16 15:50:58 ~5 min linux 📦zip
✔️ 267bc60 #5 2025-04-16 15:55:43 ~10 min tests-rpc 📄log
✔️ 267bc60 #4 2025-04-16 16:22:21 ~36 min tests 📄log

@igor-sirotin igor-sirotin force-pushed the chore/external-extkeys branch from b274af7 to b8f232d Compare April 7, 2025 12:14
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.34%. Comparing base (4f33989) to head (267bc60).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6504      +/-   ##
===========================================
- Coverage    60.45%   60.34%   -0.11%     
===========================================
  Files          833      830       -3     
  Lines       104003   103573     -430     
===========================================
- Hits         62870    62501     -369     
+ Misses       33603    33552      -51     
+ Partials      7530     7520      -10     
Flag Coverage Δ
functional 25.53% <ø> (-0.08%) ⬇️
unit 58.17% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
account/accounts.go 61.90% <ø> (ø)
account/generator/account.go 42.68% <ø> (ø)
account/generator/generator.go 71.34% <ø> (ø)
account/generator/utils.go 100.00% <ø> (ø)
account/onboarding.go 76.47% <ø> (ø)
account/utils.go 69.23% <ø> (ø)
eth-node/bridge/geth/keystore.go 88.67% <ø> (ø)
eth-node/keystore/passphrase.go 40.95% <ø> (ø)
mobile/status.go 11.86% <ø> (ø)

... and 37 files with indirect coverage changes

@igor-sirotin igor-sirotin marked this pull request as ready for review April 7, 2025 13:07
@igor-sirotin igor-sirotin requested review from a team and siddarthkay April 7, 2025 13:07
Copy link
Contributor

@siddarthkay siddarthkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice i can finally close #5423

@igor-sirotin igor-sirotin force-pushed the chore/external-extkeys branch from 7f417cd to 267bc60 Compare April 16, 2025 15:45
@igor-sirotin igor-sirotin merged commit ef99f2a into develop Apr 16, 2025
19 checks passed
@igor-sirotin igor-sirotin deleted the chore/external-extkeys branch April 16, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract extkeys repo
5 participants