code review

Author: flexsurfer

src/status_im/contexts/keycard/different_card/view.cljs

@@ -15,7 +15,7 @@
      :description      :text
      :description-text (i18n/label :t/scan-previous-keycard)}]
    [rn/view {:style {:flex 1}}]
-   [rn/view {:padding-horizontal 20}
+   [rn/view {:style {:padding-horizontal 20}}
     [quo/button {:on-press events-helper/navigate-back}
      (i18n/label :t/try-again)]]])
 

src/status_im/contexts/keycard/factory_reset/view.cljs

@@ -47,7 +47,7 @@
      :description      :text
      :description-text (i18n/label :t/keycard-empty-ready)}]
    [rn/view {:style {:flex 1}}]
-   [rn/view {:padding-horizontal 20}
+   [rn/view {:style {:padding-horizontal 20}}
     [quo/button {:on-press events-helper/navigate-back}
      (i18n/label :t/done)]]])
 
@@ -60,7 +60,7 @@
    [quo/page-top
     {:title (i18n/label :t/keycard-reset-failed)}]
    [rn/view {:style {:flex 1}}]
-   [rn/view {:padding-horizontal 20}
+   [rn/view {:style {:padding-horizontal 20}}
     [quo/button {:on-press events-helper/navigate-back}
      (i18n/label :t/try-again)]]])
 

src/status_im/contexts/keycard/not_keycard/view.cljs

@@ -19,6 +19,6 @@
     [rn/image
      {:resize-mode :contain
       :source      (resources/get-image :not-keycard)}]]
-   [rn/view {:padding-horizontal 20}
+   [rn/view {:style {:padding-horizontal 20}}
     [quo/button {:on-press events-helper/navigate-back}
      (i18n/label :t/try-again)]]])

src/status_im/contexts/settings/keycard/view.cljs

@@ -30,16 +30,6 @@
        :style style/keycard-owner-name}
       profile-name]]]])
 
-(defn- check-keycard
-  []
-  (rf/dispatch
-   [:keycard/connect
-    {:on-error
-     (fn [error]
-       (if (= error :keycard/error.keycard-wrong-profile)
-         (rf/dispatch [:keycard/on-application-info-error error])
-         (rf/dispatch [:keycard/on-application-info-error error])))}]))
-
 (defn registered-keycards
   []
   (let [keycards (rf/sub [:keycard/registered-keycards])]
@@ -65,7 +55,7 @@
      [quo/bottom-actions
       {:actions          :one-action
        :button-one-label (i18n/label :t/ready-to-scan)
-       :button-one-props {:on-press check-keycard}}]]))
+       :button-one-props {:on-press #(rf/dispatch [:keycard/connect])}}]]))
 
 (defn view
   []