Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An accepted contact request notification is not shown as per design #15210

Closed
VolodLytvynenko opened this issue Feb 28, 2023 · 3 comments
Closed
Assignees

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Feb 28, 2023

Steps to reproduce:

  1. USER_A: Send a contact request to USER_B
  2. USER_B: Accept contact request
  3. USER_A: Check a toast

Actual result:

The toast with the [x] mark is shown
image

Expected result:

A notifification should be shown as per visual
image

https://www.figma.com/file/eDfxTa9IoaCMUy5cLTp0ys/Shell-for-Mobile?node-id=4537%3A515620&t=LG0i2EpRjBM1NP7Z-0

Devices:

  • Operating System: Android, iOS

ENV:

  • Nightly 28 Feb 2023
@rasom
Copy link
Contributor

rasom commented Feb 28, 2023

@VladimrLitvinenko that looks a bit ugly but I'm wondering whether polishing of user-avatar is in scope of this PR

Screenshot 2023-02-28 at 14 09 10

@VolodLytvynenko
Copy link
Contributor Author

VolodLytvynenko commented Feb 28, 2023

@VladimrLitvinenko that looks a bit ugly but I'm wondering whether polishing of user-avatar is in scope of this PR

Screenshot 2023-02-28 at 14 09 10

@rasom Agree with you, this is not in the scope of this PR. Better to be without avatar for now than with an ugly avatar :)

@rasom
Copy link
Contributor

rasom commented Mar 1, 2023

@VladimrLitvinenko no I rather mean whether that avatar should be fixed right here. I think it is better to have it even ugly there, it will be fixed eventually.

@VolodLytvynenko VolodLytvynenko changed the title A successful mark is not shown on the toast when contact is added An accepted contact request notification is not shown as per design Mar 1, 2023
@rasom rasom closed this as completed Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants