Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share Wallet: error when scrolling between multiple QR codes #19401

Closed
Tracked by #19090
yevh-berdnyk opened this issue Mar 26, 2024 · 0 comments · Fixed by #19425
Closed
Tracked by #19090

Share Wallet: error when scrolling between multiple QR codes #19401

yevh-berdnyk opened this issue Mar 26, 2024 · 0 comments · Fixed by #19425
Assignees
@ulisesmac
Milestone
2.28.0 Alpha

Comments

@yevh-berdnyk
Copy link
Contributor

Bug Report

Problem

Cannot read property 'x' of undefined error is shown when swiping accounts on Share Wallet screen

Expected behavior

Can scroll wallet accounts without any errors

Actual behavior

Screen.Recording.2024-03-26.at.13.17.11.mov

Also on Android an address is cropped:

Screenshot 2024-03-26 at 13 38 47

On iOS it's not possible to swipe at all, error is shown immediately:

2024-03-26.13.56.21.mp4

Reproduction

  1. Add an additional account in the wallet
  2. On the Home view click Show QR Code button
  3. Click Wallet tab
  4. Try swiping left and right to navigate between different accounts

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@VolodLytvynenko VolodLytvynenko mentioned this issue Mar 26, 2024
Closed
21 tasks
@ulisesmac ulisesmac self-assigned this Mar 26, 2024
@ulisesmac ulisesmac mentioned this issue Mar 27, 2024
Merged
@VolodLytvynenko VolodLytvynenko added this to the 2.28.0 Alpha milestone Mar 28, 2024
ulisesmac added a commit that referenced this issue Apr 1, 2024
@ulisesmac
[#19401] Wallet share QR code - multiple fixes (#19425)
feb8753 
* Fix key extractions in re-frame/reg-sub

* Add `:width` to share-qr-code
  By adding this prop, `on-layout` can be skipped and the component can be properly rendered faster.

* Use `share-qr-code`'s `:width` prop in share profile shell

* Fix share qr code for wallet addresses

* Fix the height of the component being cropped.

* Fix the bottom dots not being accurately highlighted.

* Fix the blink when the component is mounted
cammellos pushed a commit that referenced this issue Apr 2, 2024
@ulisesmac @cammellos
[#19401] Wallet share QR code - multiple fixes (#19425)
5706902 
* Fix key extractions in re-frame/reg-sub

* Add `:width` to share-qr-code
  By adding this prop, `on-layout` can be skipped and the component can be properly rendered faster.

* Use `share-qr-code`'s `:width` prop in share profile shell

* Fix share qr code for wallet addresses

* Fix the height of the component being cropped.

* Fix the bottom dots not being accurately highlighted.

* Fix the blink when the component is mounted
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulisesmac ulisesmac

Labels
None yet
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Status: Done
Milestone
2.28.0 Alpha
Development

Successfully merging a pull request may close this issue.

[#19401] Wallet share QR code multiple fixes status-im/status-mobile
4 participants
@ilmotta @yevh-berdnyk @VolodLytvynenko @ulisesmac