Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👁️ Cannot read property responseSessionRequest of null #20909

Closed
shivekkhurana opened this issue Jul 29, 2024 · 2 comments · Fixed by #21123
Closed

👁️ Cannot read property responseSessionRequest of null #20909

shivekkhurana opened this issue Jul 29, 2024 · 2 comments · Fixed by #21123
Assignees
@mohsen-ghafouri
Labels
dapp-interactions wallet-connect: Refinement Fixing bugs and assuring the quality of the Wallet Connect integration
Milestone
2.31.0

Comments

@shivekkhurana
Copy link
Contributor

Related comment: #20693 (comment)

Steps (exactly the same as in the comment above):

  1. Connect to https://react-app.walletconnect.com/ using testnetwork (Sepolia)
  2. Disable testmode and login the app
  3. Trigger personal_sign event
  4. Try to sign the event
  5. Observe the result
Screenshot 2024-07-25 at 14 29 21

Originally posted by @qoqobolo in #20799 (comment)
@shivekkhurana shivekkhurana added dapp-interactions wallet-connect: Refinement Fixing bugs and assuring the quality of the Wallet Connect integration labels Jul 29, 2024
@clauxx clauxx added this to the 2.31.0 Beta milestone Aug 8, 2024
@mohsen-ghafouri mohsen-ghafouri self-assigned this Aug 23, 2024
@mohsen-ghafouri
Copy link
Contributor

@shivekkhurana I cannot reproduce this issue anymore, it looks this changes already handle the network https://github.com/status-im/status-mobile/pull/20906/files#diff-9d6f1ddb525f0c0e381e2f69d5ac04404444d837a32981c690677eb768338c6cR137

current behaviour is like this : in dapp user will see request pending
image
and in app there is no error/notification, but if user switch to the correct network, they will see request modal.

Please let me know if i should change something here, if all good we can close it.

@mohsen-ghafouri
Copy link
Contributor

Okay i found an issue that it doesn't send reject request to the dapp, and i'm going to show unsupported network toast in status app.

mohsen-ghafouri added a commit that referenced this issue Aug 23, 2024
@mohsen-ghafouri
[#20909] fix: dapp wrong network refusal
8854f6e
@mohsen-ghafouri mohsen-ghafouri mentioned this issue Aug 23, 2024
Merged
mohsen-ghafouri added a commit that referenced this issue Sep 3, 2024
@mohsen-ghafouri
[#20909] fix: dapp wrong network refusal
192283a
mohsen-ghafouri added a commit that referenced this issue Sep 3, 2024
@mohsen-ghafouri
[#20909] fix: address feedbacks
5286ae3
mohsen-ghafouri added a commit that referenced this issue Sep 5, 2024
@mohsen-ghafouri
[#20909] fix: dapp wrong network refusal
32df2a1
mohsen-ghafouri added a commit that referenced this issue Sep 5, 2024
@mohsen-ghafouri
[#20909] fix: address feedbacks
23a7cb0
mohsen-ghafouri added a commit that referenced this issue Sep 6, 2024
@mohsen-ghafouri
[#20909] fix: dapp wrong network refusal
7d3f13f
mohsen-ghafouri added a commit that referenced this issue Sep 6, 2024
@mohsen-ghafouri
[#20909] fix: address feedbacks
95b2b75
mohsen-ghafouri added a commit that referenced this issue Sep 6, 2024
@mohsen-ghafouri
[#20909] fix: dapp wrong network refusal (#21123)
3ae500f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
dapp-interactions wallet-connect: Refinement Fixing bugs and assuring the quality of the Wallet Connect integration
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.31.0
Development

Successfully merging a pull request may close this issue.

[#20909] fix: dapp wrong network refusal status-im/status-mobile
3 participants
@shivekkhurana @clauxx @mohsen-ghafouri