Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap confirmation page remains open after transaction confirmation if swap flow starts from asset long tapping #21439

Closed
VolodLytvynenko opened this issue Oct 15, 2024 · 0 comments · Fixed by #21466
Closed

Swap confirmation page remains open after transaction confirmation if swap flow starts from asset long tapping #21439

VolodLytvynenko opened this issue Oct 15, 2024 · 0 comments · Fixed by #21466
Assignees
@mohsen-ghafouri
Labels
wallet: swap wallet-core Issues for mobile wallet team
Milestone
2.32.0

Comments

@VolodLytvynenko
Copy link
Contributor

Steps:

  1. Recover user with available assets to be swapped
  2. Go to wallet main page or open any wallet account
  3. Long tap the asset -> swap
  4. Perform swap transaction

Actual result:

The swap confirmation page returns open

swap.mp4

Expected result:

The swap confirmation page closes and user navigates to activity page

OS:

IOS, Android

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17

Logs

logs.zip
@VolodLytvynenko VolodLytvynenko added this to the 2.32.0 Beta milestone Oct 15, 2024
@VolodLytvynenko VolodLytvynenko changed the title The confimartion swap page returns as open after swap transaction is confirmed if swap flow started from asset long tapping Swap confirmation page remains open after transaction confirmation if swap flow started from asset long tapping Oct 16, 2024
@VolodLytvynenko VolodLytvynenko changed the title Swap confirmation page remains open after transaction confirmation if swap flow started from asset long tapping Swap confirmation page remains open after transaction confirmation if swap flow starts from asset long tapping Oct 16, 2024
@churik churik removed the bug label Oct 17, 2024
@mohsen-ghafouri mohsen-ghafouri self-assigned this Oct 18, 2024
mohsen-ghafouri added a commit that referenced this issue Oct 18, 2024
@mohsen-ghafouri
[#21439] fix: close swap flow after confirmation
bd4c500
mohsen-ghafouri added a commit that referenced this issue Oct 18, 2024
@mohsen-ghafouri
[#21439] fix: close swap flow after confirmation
ff15f4c
@mohsen-ghafouri mohsen-ghafouri mentioned this issue Oct 18, 2024
Merged
@mohsen-ghafouri mohsen-ghafouri moved this from In Progress to Code Review in Status Desktop/Mobile Board Oct 18, 2024
mohsen-ghafouri added a commit that referenced this issue Oct 18, 2024
@mohsen-ghafouri
[#21439] fix: close swap flow after confirmation
858d91e
briansztamfater pushed a commit that referenced this issue Oct 22, 2024
@mohsen-ghafouri @briansztamfater
[#21439] fix: close swap flow after confirmation
98688b7 
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater pushed a commit that referenced this issue Oct 22, 2024
@mohsen-ghafouri @briansztamfater
[#21439] fix: close swap flow after confirmation
acab41c 
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater pushed a commit that referenced this issue Oct 22, 2024
@mohsen-ghafouri @briansztamfater
[#21439] fix: close swap flow after confirmation
ff47ac5 
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater pushed a commit that referenced this issue Oct 22, 2024
@mohsen-ghafouri @briansztamfater
[#21439] fix: close swap flow after confirmation
ce6795a 
Signed-off-by: Brian Sztamfater <[email protected]>
ilmotta pushed a commit that referenced this issue Oct 23, 2024
@mohsen-ghafouri @ilmotta
[#21439] fix: close swap flow after confirmation
73a4427 
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater pushed a commit that referenced this issue Oct 23, 2024
@mohsen-ghafouri
[#21439] fix: close swap flow after confirmation (#21466)
ea18966 
Signed-off-by: Brian Sztamfater <[email protected]>
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Oct 23, 2024
ilmotta pushed a commit that referenced this issue Oct 23, 2024
@mohsen-ghafouri @ilmotta
[#21439] fix: close swap flow after confirmation (#21466)
824094d 
Signed-off-by: Brian Sztamfater <[email protected]>
ilmotta pushed a commit that referenced this issue Oct 23, 2024
@mohsen-ghafouri @ilmotta
[#21439] fix: close swap flow after confirmation (#21466)
dffbe34 
Signed-off-by: Brian Sztamfater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
wallet: swap wallet-core Issues for mobile wallet team
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.32.0
Development

Successfully merging a pull request may close this issue.

[#21439] fix: close swap flow after confirmation status-im/status-mobile
3 participants
@churik @VolodLytvynenko @mohsen-ghafouri