Reimplement composer: add reply #15736

OmarBasem · 2023-04-25T09:02:25Z

Adds reply component to the new composer
Migrates reply component to status-im2
Adds animations for reply component appearing and disappearing

src/status_im2/contexts/chat/messages/list/view.cljs

src/status_im2/contexts/chat/messages/view.cljs

status-im-auto · 2023-04-25T09:08:29Z

Jenkins Builds

Click to see older builds (26)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`afc333f`	#1	2023-04-25 09:08:29	~5 min	`android`	🤖`apk` 📲
✔️	`afc333f`	#1	2023-04-25 09:08:31	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`afc333f`	#1	2023-04-25 09:08:49	~6 min	`tests`	📄`log`
✔️	`afc333f`	#1	2023-04-25 09:09:45	~7 min	`ios`	📱`ipa` 📲

❌	`5750b35`	#2	2023-04-25 14:02:01	~56 sec	`android`	📄`log`
❌	`5750b35`	#2	2023-04-25 14:02:13	~1 min	`android-e2e`	📄`log`

❌	`9aa082c`	#3	2023-04-25 14:05:28	~3 min	`tests`	📄`log`
✔️	`9aa082c`	#3	2023-04-25 14:07:48	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`9aa082c`	#3	2023-04-25 14:07:55	~5 min	`android`	🤖`apk` 📲
✔️	`9aa082c`	#3	2023-04-25 14:08:25	~6 min	`ios`	📱`ipa` 📲

✔️	`9bdc6ab`	#5	2023-04-25 16:41:41	~5 min	`tests`	📄`log`
✔️	`9bdc6ab`	#5	2023-04-25 16:42:03	~6 min	`android`	🤖`apk` 📲
✔️	`9bdc6ab`	#5	2023-04-25 16:42:42	~6 min	`ios`	📱`ipa` 📲
✔️	`9bdc6ab`	#5	2023-04-25 16:43:32	~7 min	`android-e2e`	🤖`apk` 📲

✔️	`b960aba`	#6	2023-04-26 05:09:28	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`b960aba`	#6	2023-04-26 05:09:39	~5 min	`android`	🤖`apk` 📲
❌	`b960aba`	#6	2023-04-26 05:09:56	~6 min	`ios`	📄`log`
✔️	`b960aba`	#6	2023-04-26 05:10:02	~6 min	`tests`	📄`log`

✔️	`9305981`	#7	2023-04-26 05:40:54	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`9305981`	#7	2023-04-26 05:40:57	~5 min	`android`	🤖`apk` 📲
✔️	`9305981`	#7	2023-04-26 05:41:10	~5 min	`tests`	📄`log`
✔️	`9305981`	#7	2023-04-26 05:41:59	~6 min	`ios`	📱`ipa` 📲

✔️	`255352e`	#8	2023-04-26 07:20:28	~6 min	`tests`	📄`log`
✔️	`255352e`	#8	2023-04-26 07:20:44	~6 min	`android`	🤖`apk` 📲
✔️	`255352e`	#8	2023-04-26 07:20:47	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`255352e`	#8	2023-04-26 07:23:11	~8 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`03a4005`	#9	2023-04-27 05:04:55	~5 min	`android`	🤖`apk` 📲
✔️	`03a4005`	#9	2023-04-27 05:05:40	~6 min	`ios`	📱`ipa` 📲
✔️	`03a4005`	#9	2023-04-27 05:06:24	~6 min	`tests`	📄`log`
✔️	`03a4005`	#9	2023-04-27 05:07:10	~7 min	`android-e2e`	🤖`apk` 📲

✔️	`b43e13e`	#11	2023-04-27 14:47:30	~6 min	`android`	🤖`apk` 📲
✔️	`b43e13e`	#11	2023-04-27 14:47:48	~6 min	`tests`	📄`log`
✔️	`b43e13e`	#11	2023-04-27 14:47:51	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`b43e13e`	#11	2023-04-27 14:53:00	~11 min	`ios`	📱`ipa` 📲

src/status_im2/contexts/chat/bottom_sheet_composer/reply/style.cljs

src/status_im2/contexts/chat/bottom_sheet_composer/reply/view.cljs

src/status_im2/contexts/chat/messages/list/view.cljs

src/status_im2/contexts/chat/messages/view.cljs

src/status_im2/contexts/chat/bottom_sheet_composer/reply/view.cljs

OmarBasem · 2023-04-25T15:29:18Z

Thanks for your reviews @ilmotta.
Actually, all of these reviews are for code that was copied as is :) I only changed the parts that were using code from status-im1. Anyways I will look into it since we are at it.

ilmotta · 2023-04-25T16:29:19Z

Thanks for your reviews @ilmotta. Actually, all of these reviews are for code that was copied as is :) I only changed the parts that were using code from status-im1. Anyways I will look into it since we are at it.

Ouch, I frequently miss this because it's hard for me to know exactly what's copied and what's not. Thank you!

status-im-auto · 2023-04-25T17:23:42Z

28% of end-end tests have passed

Total executed tests: 25
Failed tests: 18
Passed tests: 7
Not executed tests: 4

IDs of not executed tests: 702846,702742,702850,702851

IDs of failed tests: 702947,702840,702733,702958,702855,702844,702782,702786,702894,702783,702845,702841,702936,702957,702839,702838,702843,702784

Not executed tests (4)

Click to expand

Rerun not executed tests

Failed tests (18)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
3. test_community_mentions_push_notification, id: 702786
Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
4. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
5. test_community_leave, id: 702845
Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
6. test_community_unread_messages_badge, id: 702841
Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
7. test_community_message_delete, id: 702839
Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Find `CheckBox` by `accessibility id`: `checkbox-off` Device 2: Find `CheckBox` by `accessibility id`: `checkbox-off` Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen [[blocked by 14797]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
9. test_community_message_edit, id: 702843
Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
# STEP: Verify Device1 can not edit and delete received message from Device2 Device 2: Sending message 'smth I should edit' critical/chats/test_1_1_public_chats.py:1220: in test_1_1_chat_text_message_delete_push_disappear self.chat_2.send_message(message_after_edit_1_1) ../views/chat_view.py:933: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element; also Unexpected Alert is shown: 'Cannot read property 'current' of null' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_edit_message, id: 702855
Device 2: Tap on found: Button Device 2: Find `ChatMessageInput` by `accessibility id`: `chat-message-input` critical/chats/test_1_1_public_chats.py:1202: in test_1_1_chat_edit_message self.chat_2.edit_message_in_chat(message_before_edit_1_1, message_after_edit_1_1) ../views/chat_view.py:955: in edit_message_in_chat self.chat_message_input.clear() ../views/base_element.py:356: in clear self.find_element().clear() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: ChatMessageInput by accessibility id: `chat-message-input` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'current' of null' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 1: Tap on found: Button Device 1: Find `EditBox` by `xpath`: `//[@content-desc='reply-cancel-button']/preceding::android.widget.TextView[2]` critical/chats/test_1_1_public_chats.py:972: in test_1_1_chat_emoji_send_reply_and_open_link actual_text = self.chat_1.quote_username_in_message_input.text ../views/base_element.py:209: in text return self.find_element().text ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 1: EditBox by xpath: `//[@content-desc='reply-cancel-button']/preceding::android.widget.TextView[2]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
# STEP: Device2 checks "Sending" status when sending message from offline Device 2: Sending message 'test message' critical/chats/test_1_1_public_chats.py:1284: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.chat_2.send_message(message_1) ../views/chat_view.py:933: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element; also Unexpected Alert is shown: 'Cannot read property 'current' of null' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
5. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device 2: Could not reach ChatsTab element by pressing back Device 2: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` critical/chats/test_1_1_public_chats.py:1311: in test_1_1_chat_delete_via_long_press_relogin self.home_2.chats_tab.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'current' of null' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: medium/test_activity_center.py:228: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: medium/test_activity_center.py:228: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen [[Blocked by 15500]]
3. test_navigation_jump_to, id: 702936
Device 2: Find `CheckBox` by `accessibility id`: `checkbox-off` Device 2: Find `CheckBox` by `accessibility id`: `checkbox-off` Test setup failed: medium/test_activity_center.py:228: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_activity_center_mentions, id: 702957
Test setup failed: medium/test_activity_center.py:228: in prepare_devices self.community_2.join_community() ../views/chat_view.py:372: in join_community self.checkbox_button.scroll_and_click() ../views/base_element.py:182: in scroll_and_click self.scroll_to_element(direction=direction) ../views/base_element.py:177: in scroll_to_element raise NoSuchElementException( Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen [[Blocked by 15500]]

Passed tests (7)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

src/status_im2/constants.cljs

src/status_im2/contexts/chat/messages/list/new_temp_view.cljs

OmarBasem · 2023-04-27T14:38:27Z

I currently have 2 pending PRs with a dependency for this one. Since the composer is still disabled anyways, I'll merge this one now and will mention this PR's tasks to be QA tested on one of the other PRs.

status-im-auto · 2023-04-27T16:17:27Z

90% of end-end tests have passed

Total executed tests: 29
Failed tests: 3
Passed tests: 26
Not executed tests: 1

IDs of not executed tests: 703086

IDs of failed tests: 702838,702742,702850

Not executed tests (1)

Click to expand

Rerun not executed tests

Failed tests (3)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device 1: Find `ChatMessageInput` by `accessibility id`: `chat-message-input`
Device 1: Clear text in `ChatMessageInput`

critical/test_public_chat_browsing.py:352: in test_community_copy_and_paste_message_in_chat_input
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message mmmeowesage_text text was not copied in community channel
E    Message https://status.im text was not copied in community channel

Device sessions

Device 1:

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850

Device 2: Tap on found: Button
Device 2: Find Text by xpath: //*[@content-desc="pending-contact-requests-count"]/android.widget.TextView

medium/test_activity_center.py:138: in test_activity_center_contact_request_decline
    if self.home_2.pending_contact_request_text.text != '1':
../views/base_element.py:391: in text
    text = self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Text by xpath: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen

[[Blocked by 15500]]

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'hello' is under today
Device 2: Looking for a message by text: hello

critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

[[blocked by 14797]]

Device sessions

Device 1:

Device 2:

Passed tests (26)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

OmarBasem added request-manual-qa composer labels Apr 25, 2023

OmarBasem self-assigned this Apr 25, 2023

OmarBasem commented Apr 25, 2023

View reviewed changes

src/status_im2/contexts/chat/messages/list/view.cljs Outdated Show resolved Hide resolved

OmarBasem commented Apr 25, 2023

View reviewed changes

src/status_im2/contexts/chat/messages/view.cljs Outdated Show resolved Hide resolved

OmarBasem requested review from ilmotta, yqrashawn and ibrkhalil April 25, 2023 09:04

OmarBasem mentioned this pull request Apr 25, 2023

Reimplement composer - edit message #15730

Closed

OmarBasem force-pushed the reimplement-composer-reply branch from afc333f to 5750b35 Compare April 25, 2023 14:00

ilmotta reviewed Apr 25, 2023

View reviewed changes

ilmotta approved these changes Apr 25, 2023

View reviewed changes

OmarBasem force-pushed the reimplement-composer-reply branch from 9aa082c to 80df384 Compare April 25, 2023 16:34

OmarBasem force-pushed the reimplement-composer-reply branch from 9bdc6ab to b960aba Compare April 26, 2023 05:03

flexsurfer reviewed Apr 26, 2023

View reviewed changes

src/status_im2/constants.cljs Outdated Show resolved Hide resolved

src/status_im2/contexts/chat/messages/list/new_temp_view.cljs Show resolved Hide resolved

OmarBasem force-pushed the reimplement-composer-reply branch from 9305981 to 255352e Compare April 26, 2023 07:14

ilmotta mentioned this pull request Apr 26, 2023

[#15741] Fix error on tapping pinned message #15754

Merged

OmarBasem force-pushed the reimplement-composer-reply branch from 255352e to 03a4005 Compare April 27, 2023 04:59

OmarBasem removed the request-manual-qa label Apr 27, 2023

OmarBasem added 6 commits April 27, 2023 18:40

composer reply

4ac85ce

lint

22c76c4

revert pod

39d2b88

review

438ac7c

lint

6079f3b

review

ea1eafe

OmarBasem force-pushed the reimplement-composer-reply branch from 03a4005 to ea1eafe Compare April 27, 2023 14:40

disable composer

b43e13e

OmarBasem merged commit 3e9d5dd into develop Apr 27, 2023

OmarBasem deleted the reimplement-composer-reply branch April 27, 2023 16:20

OmarBasem mentioned this pull request May 5, 2023

feat: new composer complete 🎉 #15818

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reimplement composer: add reply #15736

Reimplement composer: add reply #15736

OmarBasem commented Apr 25, 2023

status-im-auto commented Apr 25, 2023 •

edited

Loading

OmarBasem commented Apr 25, 2023 •

edited

Loading

ilmotta commented Apr 25, 2023

status-im-auto commented Apr 25, 2023

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

OmarBasem commented Apr 27, 2023

status-im-auto commented Apr 27, 2023

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Reimplement composer: add reply #15736

Reimplement composer: add reply #15736

Conversation

OmarBasem commented Apr 25, 2023

status-im-auto commented Apr 25, 2023 • edited Loading

Jenkins Builds

OmarBasem commented Apr 25, 2023 • edited Loading

ilmotta commented Apr 25, 2023

status-im-auto commented Apr 25, 2023

28% of end-end tests have passed

Not executed tests (4)

Failed tests (18)

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Passed tests (7)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

OmarBasem commented Apr 27, 2023

status-im-auto commented Apr 27, 2023

90% of end-end tests have passed

Not executed tests (1)

Failed tests (3)

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Passed tests (26)

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented Apr 25, 2023 •

edited

Loading

OmarBasem commented Apr 25, 2023 •

edited

Loading