Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entry points for Quo2 Preview #16843

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Conversation

smohamedjavid
Copy link
Member

@smohamedjavid smohamedjavid commented Aug 2, 2023

Summary

This PR adds two new entry points for the Quo2 preview screen without having to log in to the app:

New to status (onboarding) Login

Additionally, this PR updates the theme switcher to be sticky at the top of the Quo2 preview screen to quickly change the theme without having to scroll all the way top.

Platforms

  • Android
  • iOS

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Aug 2, 2023

Jenkins Builds

Click to see older builds (11)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 26591f0 #1 2023-08-02 14:30:28 ~5 min android-e2e 🤖apk 📲
✔️ 26591f0 #1 2023-08-02 14:30:41 ~6 min android 🤖apk 📲
✔️ 26591f0 #1 2023-08-02 14:33:18 ~8 min tests 📄log
✔️ 26591f0 #1 2023-08-02 14:34:46 ~10 min ios 📱ipa 📲
✔️ bb36748 #2 2023-08-02 14:42:38 ~6 min android-e2e 🤖apk 📲
✔️ bb36748 #2 2023-08-02 14:43:13 ~7 min ios 📱ipa 📲
✔️ bb36748 #2 2023-08-02 14:45:22 ~9 min android 🤖apk 📲
✔️ a38cea6 #3 2023-08-02 14:53:20 ~7 min android-e2e 🤖apk 📲
✔️ a38cea6 #3 2023-08-02 14:54:52 ~9 min android 🤖apk 📲
✔️ a38cea6 #3 2023-08-02 14:57:17 ~11 min tests 📄log
✔️ a38cea6 #3 2023-08-02 15:02:16 ~16 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 31e3e75 #4 2023-08-02 17:14:20 ~6 min android-e2e 🤖apk 📲
✔️ 31e3e75 #4 2023-08-02 17:16:37 ~8 min android 🤖apk 📲
✔️ 31e3e75 #4 2023-08-02 17:17:29 ~9 min tests 📄log
✔️ 31e3e75 #4 2023-08-02 17:19:31 ~11 min ios 📱ipa 📲
✔️ 418e1b7 #5 2023-08-03 18:07:22 ~5 min ios 📱ipa 📲
✔️ 418e1b7 #5 2023-08-03 18:07:39 ~6 min android-e2e 🤖apk 📲
✔️ 418e1b7 #5 2023-08-03 18:07:51 ~6 min android 🤖apk 📲
✔️ 418e1b7 #5 2023-08-03 18:09:47 ~8 min tests 📄log

@smohamedjavid smohamedjavid force-pushed the feature/quo2-preview-entry branch from 26591f0 to bb36748 Compare August 2, 2023 14:35
@smohamedjavid smohamedjavid marked this pull request as ready for review August 2, 2023 14:48
@J-Son89
Copy link
Contributor

J-Son89 commented Aug 2, 2023

I really like this idea and think it's in the right direction, nice work @smohamedjavid!! :)
I think we will gain a lot by gathering feedback in a document before adding features to the preview screens so we can figure out what best suits our use case :)
@ilmotta - did you start the notion document by any chance? 🤔

@smohamedjavid smohamedjavid force-pushed the feature/quo2-preview-entry branch from a38cea6 to 31e3e75 Compare August 2, 2023 17:07
@ilmotta
Copy link
Contributor

ilmotta commented Aug 2, 2023

I really like this idea and think it's in the right direction, nice work @smohamedjavid!! :) I think we will gain a lot by gathering feedback in a document before adding features to the preview screens so we can figure out what best suits our use case :) @ilmotta - did you start the notion document by any chance? thinking

@J-Son89: I only have a few private notes. Give me a day and I'll open to collect ideas from designers and devs.

Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @smohamedjavid, this will make development much easier :) please share this out once it's merged 🙌

@smohamedjavid smohamedjavid force-pushed the feature/quo2-preview-entry branch from 31e3e75 to 418e1b7 Compare August 3, 2023 18:01
@smohamedjavid smohamedjavid merged commit f6ce637 into develop Aug 3, 2023
@smohamedjavid smohamedjavid deleted the feature/quo2-preview-entry branch August 3, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants