Fix incorrect usage of functional component #17281

ilmotta · 2023-09-13T14:14:25Z

Summary

As reported by @mohsen-ghafouri, a recent commit 344c9ba introduced a regression in the preview screens due to the incorrect usage of a Reagent functional component.

Bug: every keypress on an input field of the descriptor re-rendered the whole functional component and the input focus was lost.

As we know from past scars, we should never use this pattern:

(defn component
  []
  [:f>
   (fn []
     ...)])

status: ready

status-im-auto · 2023-09-13T14:20:39Z

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`f26a1dd`	#1	2023-09-13 14:20:39	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`f26a1dd`	#1	2023-09-13 14:21:19	~6 min	`android`	🤖`apk` 📲
✔️	`f26a1dd`	#1	2023-09-13 14:26:20	~11 min	`ios`	📱`ipa` 📲
✔️	`f26a1dd`	#1	2023-09-13 14:26:33	~11 min	`tests`	📄`log`

status-im-auto · 2023-09-13T15:11:17Z

14% of end-end tests have passed

Total executed tests: 43
Failed tests: 37
Passed tests: 6

IDs of failed tests: 702809,702782,702784,703194,702859,702732,703133,702957,702851,702840,703495,703086,702948,702894,702745,702783,702742,703297,703503,703496,702936,702855,703202,702786,702839,702947,702838,702844,702843,702807,702731,702808,702730,702845,702958,703382,702841

Failed tests (37)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Test setup failed: critical/test_public_chat_browsing.py:552: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element
2. test_community_one_image_send_reply, id: 702859
Test setup failed: critical/test_public_chat_browsing.py:552: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element
3. test_community_emoji_send_copy_paste_reply, id: 702840
Test setup failed: critical/test_public_chat_browsing.py:552: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element
4. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: critical/test_public_chat_browsing.py:552: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element
5. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: critical/test_public_chat_browsing.py:552: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//[@text="User found"]` is not found on the screen after wait_for_visibility_of_element [[Message can be missed after unblock: https://github.com//issues/16873]]*
6. test_community_message_delete, id: 702839
Test setup failed: critical/test_public_chat_browsing.py:552: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 1: Find `EditBox` by `accessibility id`: `enter-contact-code-input` Device 1: Type `` to `EditBox` Test setup failed: critical/test_public_chat_browsing.py:552: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Test setup failed: critical/test_public_chat_browsing.py:552: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element
9. test_community_message_edit, id: 702843
Test setup failed: critical/test_public_chat_browsing.py:552: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element
10. test_community_unread_messages_badge, id: 702841
Test setup failed: critical/test_public_chat_browsing.py:552: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device 1: Tap on found: CommunitiesTab Device 1: Looking for community: 'open community' Test setup failed: medium/test_activity_center.py:319: in prepare_devices self.community_1.share_community(self.community_name, self.username_2) ../views/chat_view.py:497: in share_community community_element.long_press_until_element_is_shown(self.share_community_button) ../views/base_element.py:317: in long_press_until_element_is_shown element = self.find_element() ../views/home_view.py:74: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'open community')]/..` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: medium/test_activity_center.py:319: in prepare_devices self.community_1.share_community(self.community_name, self.username_2) ../views/chat_view.py:497: in share_community community_element.long_press_until_element_is_shown(self.share_community_button) ../views/base_element.py:317: in long_press_until_element_is_shown element = self.find_element() ../views/home_view.py:74: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'open community')]/..` is not found on the screen after wait_for_visibility_of_element

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device 2: Long press on `ChatElement` Device 2: Find `Button` by `xpath`: `//[@text="Delete chat"]` critical/chats/test_1_1_public_chats.py:1465: in test_1_1_chat_delete_via_long_press_relogin self.home_2.delete_chat_long_press(username=self.username_1) ../views/home_view.py:504: in delete_chat_long_press self.delete_chat_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[@text="Delete chat"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message was not delivered after resending from offline E Message status was not changed to Delivered, it's Sent after back up online!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_mute_chat, id: 703496
Device 1: Long press on `ChatElement` Device 1: Find `MuteButton` by `accessibility id`: `mute-chat` critical/chats/test_1_1_public_chats.py:1439: in test_1_1_chat_mute_chat if self.home_1.mute_chat_button.text != transl["unmute-chat"]: ../views/home_view.py:213: in text return self.find_element().find_element(by=MobileBy.CLASS_NAME, value="android.widget.TextView").text ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: MuteButton by accessibility id: `mute-chat` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device 1: Tap on found: CommunitiesTab Device 1: Looking for community: 'open community' Test setup failed: medium/test_activity_center.py:171: in prepare_devices self.community_1.share_community(self.community_name, self.username_2) ../views/chat_view.py:497: in share_community community_element.long_press_until_element_is_shown(self.share_community_button) ../views/base_element.py:317: in long_press_until_element_is_shown element = self.find_element() ../views/home_view.py:74: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'open community')]/..` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: medium/test_activity_center.py:171: in prepare_devices self.community_1.share_community(self.community_name, self.username_2) ../views/chat_view.py:497: in share_community community_element.long_press_until_element_is_shown(self.share_community_button) ../views/base_element.py:317: in long_press_until_element_is_shown element = self.find_element() ../views/home_view.py:74: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'open community')]/..` is not found on the screen after wait_for_visibility_of_element

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 2: Find Button by xpath: //*[@text="Paste"]
Device 2: Tap on found: Button

medium/test_activity_center.py:95: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_2.element_by_translation_id("user-found").wait_for_visibility_of_element(10)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_mute_chat, id: 703495
Test setup failed: critical/chats/test_group_chat.py:202: in prepare_devices self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>, ../views/home_view.py:412: in create_group_chat chat.chat_name_editbox.send_keys(group_chat_name) ../views/base_element.py:367: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `chat-name-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
3. test_group_chat_send_image_save_and_share, id: 703297
Test setup failed: critical/chats/test_group_chat.py:202: in prepare_devices self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>, ../views/home_view.py:412: in create_group_chat chat.chat_name_editbox.send_keys(group_chat_name) ../views/base_element.py:367: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `chat-name-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
4. test_group_chat_reactions, id: 703202
Test setup failed: critical/chats/test_group_chat.py:202: in prepare_devices self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>, ../views/home_view.py:412: in create_group_chat chat.chat_name_editbox.send_keys(group_chat_name) ../views/base_element.py:367: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `chat-name-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
5. test_group_chat_join_send_text_messages_push, id: 702807
Device 1: Tap on found: Button Device 1: Find `EditBox` by `accessibility id`: `chat-name-input` Test setup failed: critical/chats/test_group_chat.py:202: in prepare_devices self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>, ../views/home_view.py:412: in create_group_chat chat.chat_name_editbox.send_keys(group_chat_name) ../views/base_element.py:367: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `chat-name-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
6. test_group_chat_offline_pn, id: 702808
Test setup failed: critical/chats/test_group_chat.py:202: in prepare_devices self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>, ../views/home_view.py:412: in create_group_chat chat.chat_name_editbox.send_keys(group_chat_name) ../views/base_element.py:367: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `chat-name-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 2: Find `ChatElementByText` by `xpath`: `//[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` Device 2: Long press on `ChatElementByText` until expected element is shown critical/chats/test_1_1_public_chats.py:971: in test_1_1_chat_emoji_send_reply_and_open_link self.chat_2.set_reaction(url_message) ../views/chat_view.py:1064: in set_reaction self.chat_element_by_text(message).long_press_until_element_is_shown(element) ../views/base_element.py:321: in long_press_until_element_is_shown action.long_press(element).release().perform() /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/common/touch_action.py:174: in perform self._driver.execute(Command.TOUCH_ACTION, params) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace)) The element 'By.xpath: //[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']' does not exist in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception E Stacktrace: E io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //*[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']' does not exist in DOM anymore E at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:117) E at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153) E at io.appium.uiautomator2.handler.Location.safeHandle(Location.java:23) E at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59) E at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277) E at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271) E at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435) E at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293) E at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267) E at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911) E at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131) E at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611) E at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552) E at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466) E at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438) E at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140) E at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144) E at java.lang.Thread.run(Thread.java:919) Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 1: Tap on found: ProfilePictureElement Device 1: Find `Button` by `xpath`: `//[@text="Select from gallery"]` critical/chats/test_1_1_public_chats.py:1087: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.profile_1.edit_profile_picture('sauce_logo.png') ../views/profile_view.py:429: in edit_profile_picture self.select_from_gallery_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@text="Select from gallery"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_edit_message, id: 702855
Device 2: Find `Button` by `xpath`: `//[@content-desc=":chat-floating-screen"]//[@content-desc="jump-to"]` critical/chats/test_1_1_public_chats.py:1185: in test_1_1_chat_edit_message self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:642: in jump_to_card_by_text self.click_on_floating_jump_to() ../views/base_view.py:625: in click_on_floating_jump_to self.jump_to_button.accessibility_id)).click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[@content-desc=":chat-floating-screen"]//[@content-desc="jump-to"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
5. test_1_1_chat_message_reaction, id: 702730
Device 1: Find `Button` by `accessibility id`: `authors-for-reaction-2` Device 1: Tap on found: Button `critical/chats/test_1_1_public_chats.py:918: in test_1_1_chat_message_reaction self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Incorrect users are shown for 'thumbs-up' reaction.` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device 1: Could not reach home view by pressing system back button Device 1: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` critical/test_public_chat_browsing.py:447: in test_restore_multiaccount_with_waku_backup_remove_switch profile = self.home.profile_button.click() ../views/base_view.py:145: in click ChatsTab(self.driver).click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device 1: Long press on `ChatElementByText` Device 1: Find `Button` by `xpath`: `//[@text="Copy text"]` critical/test_public_chat_browsing.py:366: in test_community_copy_and_paste_message_in_chat_input self.channel.copy_message_text(message) ../views/chat_view.py:1048: in copy_message_text self.element_by_translation_id("copy-text").click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@text="Copy text"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] https://github.com//issues/17175]]
4. test_community_mute_community_and_channel, id: 703382
Device 1: Getting cats channel element in community Device 1: Looking for chat: 'cats' critical/test_public_chat_browsing.py:409: in test_community_mute_community_and_channel self.community_view.get_channel(self.channel_name).long_press_element() ../views/base_element.py:311: in long_press_element element = self.find_element() ../views/home_view.py:74: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElement by xpath:`//[@content-desc='channel-list-item']//[starts-with(@text,'# cats')]/..` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Test setup failed: critical/test_public_chat_browsing.py:1047: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element
2. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: critical/test_public_chat_browsing.py:1047: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element
3. test_community_mentions_push_notification, id: 702786
Device 1: Find `EditBox` by `accessibility id`: `enter-contact-code-input` Device 1: Type `` to `EditBox` Test setup failed: critical/test_public_chat_browsing.py:1047: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//[@text="User found"]` is not found on the screen after wait_for_visibility_of_element [[Issue with username in PN, issue #6 in 15500]]* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_community_leave, id: 702845
Test setup failed: critical/test_public_chat_browsing.py:1047: in prepare_devices self.home_1.add_contact(self.public_key_2) ../views/home_view.py:392: in add_contact chat.element_by_translation_id("user-found").wait_for_visibility_of_element() ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//*[@text="User found"]` is not found on the screen after wait_for_visibility_of_element

Passed tests (6)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

OmarBasem

Thanks for the fix! 👍

Fix incorrect usage of functional component

f26a1dd

ilmotta requested review from ajayesivan, clauxx, OmarBasem and mohsen-ghafouri September 13, 2023 14:14

ilmotta self-assigned this Sep 13, 2023

mohsen-ghafouri approved these changes Sep 13, 2023

View reviewed changes

ajayesivan approved these changes Sep 13, 2023

View reviewed changes

OmarBasem approved these changes Sep 13, 2023

View reviewed changes

ilmotta merged commit dab4d95 into develop Sep 13, 2023

ilmotta deleted the fix/incorrect-usage-of-functional-reagent-component branch September 13, 2023 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix incorrect usage of functional component #17281

Fix incorrect usage of functional component #17281

ilmotta commented Sep 13, 2023 •

edited

Loading

status-im-auto commented Sep 13, 2023 •

edited

Loading

status-im-auto commented Sep 13, 2023

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePR:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

OmarBasem left a comment

Fix incorrect usage of functional component #17281

Fix incorrect usage of functional component #17281

Conversation

ilmotta commented Sep 13, 2023 • edited Loading

Summary

status-im-auto commented Sep 13, 2023 • edited Loading

Jenkins Builds

status-im-auto commented Sep 13, 2023

14% of end-end tests have passed

Failed tests (37)

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePR:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Passed tests (6)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

OmarBasem left a comment

Choose a reason for hiding this comment

ilmotta commented Sep 13, 2023 •

edited

Loading

status-im-auto commented Sep 13, 2023 •

edited

Loading