Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process backedup(profile/settings) signal #17306

Merged
merged 1 commit into from
Sep 19, 2023
Merged

process backedup(profile/settings) signal #17306

merged 1 commit into from
Sep 19, 2023

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Sep 18, 2023

fixes issue one

Platforms

  • Android
  • iOS

status: ready

@qfrank qfrank self-assigned this Sep 18, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 18, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 26f4639 #1 2023-09-18 07:54:23 ~5 min android 🤖apk 📲
✔️ 26f4639 #1 2023-09-18 07:55:42 ~6 min ios 📱ipa 📲
✔️ 26f4639 #1 2023-09-18 07:58:05 ~9 min android-e2e 🤖apk 📲
✔️ 26f4639 #1 2023-09-18 07:58:43 ~9 min tests 📄log
✔️ aa1410a #2 2023-09-19 13:58:26 ~7 min android 🤖apk 📲
✔️ aa1410a #2 2023-09-19 13:58:45 ~7 min android-e2e 🤖apk 📲
✔️ aa1410a #2 2023-09-19 13:59:42 ~8 min ios 📱ipa 📲
✔️ aa1410a #2 2023-09-19 14:02:24 ~10 min tests 📄log

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 43
Failed tests: 6
Passed tests: 37

IDs of failed tests: 702732,702894,703503,702786,702731,702808

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Passed tests (37)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    @qfrank qfrank requested a review from ibrkhalil September 18, 2023 11:04
    @VolodLytvynenko VolodLytvynenko self-assigned this Sep 18, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    hi @qfrank thank you for PR. Here is a found issue:

    ISSUE 1: The identifier rings are displayed on avatars for users with a set ENS until the user relogs.

    Steps to Reproduce:

    1. Recover the user with a backed-up ENS (fatigue inquiry accident utility today tone renew steak lawn reject found lawn).
    2. Send a message in any chat.
    3. Check your avatar.
    4. Check the avatar on the 'jump to' page.

    Actual Result:

    The identifier rings are shown on avatars until the user logs out and logs back in.
    image
    image

    Expected Result:

    The identifier rings should not be displayed on avatars if users have set an ENS.

    @qfrank
    Copy link
    Contributor Author

    qfrank commented Sep 19, 2023 •
    edited
    Loading

    hi @qfrank thank you for PR. Here is a found issue:

    ISSUE 1: The identifier rings are displayed on avatars for users with a set ENS until the user relogs.

    Steps to Reproduce:

    1. Recover the user with a backed-up ENS (fatigue inquiry accident utility today tone renew steak lawn reject found lawn).
    2. Send a message in any chat.
    3. Check your avatar.
    4. Check the avatar on the 'jump to' page.

    Actual Result:

    The identifier rings are shown on avatars until the user logs out and logs back in. image image

    Expected Result:

    The identifier rings should not be displayed on avatars if users have set an ENS.

    Hi @VolodLytvynenko , thanks for your feedback, i believe issue 1 is not relate to this PR, but i can take it as followup. WDYT?

    @VolodLytvynenko
    Copy link
    Contributor

    VolodLytvynenko commented Sep 19, 2023 •
    edited
    Loading

    WDYT?

    Hi @qfrank agree with you. This issue can be fixed in a separate follow-up. No other issues from my side. Current PR can be merged

    @VolodLytvynenko VolodLytvynenko mentioned this pull request Sep 19, 2023
    Closed
    @qfrank qfrank force-pushed the fix/handle-backedup-ens branch from 26f4639 to aa1410a Compare September 19, 2023 13:51
    @qfrank qfrank merged commit cb9ae21 into develop Sep 19, 2023
    @qfrank qfrank deleted the fix/handle-backedup-ens branch September 19, 2023 14:06
    ibrkhalil pushed a commit that referenced this pull request Oct 1, 2023
    @qfrank @ibrkhalil
    process backedup(profile/settings) signal (#17306)
    3852008
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @vkjr vkjr vkjr approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    Assignees

    @qfrank qfrank

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @qfrank @status-im-auto @VolodLytvynenko @vkjr @ibrkhalil