Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction summary design followup fixes #17360

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Transaction summary design followup fixes #17360

merged 1 commit into from
Sep 27, 2023

Conversation

vkjr
Copy link
Contributor

@vkjr vkjr commented Sep 20, 2023

fixes #17266

Summary

Transaction summary component updated to match the design.
Height matches the component in Figma, whereas width depends on place of use.

Visual comparison:
Screenshot 2023-09-20 at 15 21 01

status: ready

@vkjr vkjr self-assigned this Sep 20, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 20, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 76e9383 #1 2023-09-20 14:46:35 ~6 min android 🤖apk 📲
✔️ 76e9383 #1 2023-09-20 14:46:39 ~6 min android-e2e 🤖apk 📲
✔️ 76e9383 #1 2023-09-20 14:51:54 ~11 min tests 📄log
✔️ 76e9383 #1 2023-09-20 14:56:28 ~15 min ios 📱ipa 📲
✔️ 1f19ed0 #2 2023-09-25 10:22:02 ~5 min android-e2e 🤖apk 📲
✔️ 1f19ed0 #2 2023-09-25 10:23:31 ~7 min ios 📱ipa 📲
✔️ 1f19ed0 #2 2023-09-25 10:25:42 ~9 min android 🤖apk 📲
✔️ 1f19ed0 #2 2023-09-25 10:25:58 ~9 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cc2e2bb #3 2023-09-27 09:40:58 ~6 min android 🤖apk 📲
✔️ cc2e2bb #3 2023-09-27 09:41:11 ~6 min ios 📱ipa 📲
✔️ cc2e2bb #3 2023-09-27 09:44:12 ~9 min android-e2e 🤖apk 📲
✔️ cc2e2bb #3 2023-09-27 09:44:47 ~9 min tests 📄log
✔️ 94aed65 #4 2023-09-27 10:49:52 ~6 min ios 📱ipa 📲
✔️ 94aed65 #4 2023-09-27 10:52:00 ~8 min android-e2e 🤖apk 📲
✔️ 94aed65 #4 2023-09-27 10:52:17 ~8 min android 🤖apk 📲
✔️ 94aed65 #4 2023-09-27 10:54:08 ~10 min tests 📄log

briansztamfater
briansztamfater approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@briansztamfater briansztamfater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vkjr vkjr force-pushed the transactions-summary-design-fix branch from 76e9383 to 1f19ed0 Compare September 25, 2023 10:16
@status-im-auto
Copy link
Member

72% of end-end tests have passed

Total executed tests: 43
Failed tests: 12
Passed tests: 31

IDs of failed tests: 702809,703086,703202,702732,702731,703503,702786,702808,702894,703297,702851,702783

Failed tests (12)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find `Text` by `xpath`: `//*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView`
    Device 2: `Text` is `Sent` 

    critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not delivered after resending from offline
E    Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 1: Find ChatsTab by accessibility id: chats-stack-tab
    Device 1: Tap on found: ChatsTab 

    medium/test_activity_center.py:102: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/test_public_chat_browsing.py:1201: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 bold text in asterics is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    bold text in underscores is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    italic text in asteric is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    italic text in underscore is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    inline code is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    code blocks is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    quote reply (one row) is not displayed with markdown in community channel for the recipient (device 1)



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Tap on found: Button
    Device 1: Click until Text by accessibility id: community-description-text will be presented 

    critical/test_public_chat_browsing.py:1028: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Community element
E    New messages counter is not shown in community channel element



    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202

    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView
    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView 

    critical/chats/test_group_chat.py:252: in test_group_chat_reactions
    message_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(2)
../views/base_element.py:181: in wait_for_element_text
    self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % (
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: `1` is not equal to expected `2` in 30 sec



    Device sessions

    2. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    3. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline
E    message from old member if not shown for device 2



    Device sessions

    4. test_group_chat_send_image_save_and_share, id: 703297

    # STEP: Admin checks image message
    Device 1: Looking for a message by text: test image 

    critical/chats/test_group_chat.py:357: in test_group_chat_send_image_save_and_share
    self.chats[0].chat_element_by_text(image_description).wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'test image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Passed tests (31)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    7. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_mute_community_and_channel, id: 703382
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    4. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    5. test_community_undo_delete_message, id: 702869
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_message_edit, id: 702843
    Device sessions

    4. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    5. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_delete, id: 702839
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    @vkjr
    Copy link
    Contributor Author

    vkjr commented Sep 25, 2023

    @Francesca-G, could you please review this one? Thanks!

    ulisesmac
    ulisesmac approved these changes Sep 26, 2023
    View reviewed changes
    Copy link
    Contributor

    @ulisesmac ulisesmac left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM 👍

    @vkjr vkjr force-pushed the transactions-summary-design-fix branch from 1f19ed0 to cc2e2bb Compare September 27, 2023 09:34
    @vkjr vkjr force-pushed the transactions-summary-design-fix branch from cc2e2bb to 94aed65 Compare September 27, 2023 10:43
    @vkjr vkjr merged commit 79f7b6c into develop Sep 27, 2023
    @vkjr vkjr deleted the transactions-summary-design-fix branch September 27, 2023 10:54
    ibrkhalil pushed a commit that referenced this pull request Oct 1, 2023
    @vkjr @ibrkhalil
    Transaction summary design followup fixes (#17360)
    96b5182
    clauxx pushed a commit that referenced this pull request Oct 3, 2023
    @vkjr @clauxx
    Transaction summary design followup fixes (#17360)
    d84a8fc
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @briansztamfater briansztamfater briansztamfater approved these changes

    @ulisesmac ulisesmac ulisesmac approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @vkjr vkjr

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Fix design followup for transaction summary component
    5 participants
    @vkjr @status-im-auto @briansztamfater @ulisesmac @Francesca-G