Composer collapsing when editing canceled/done #17785
Conversation
Jenkins BuildsClick to see older builds (42)
|
clauxx
force-pushed
the
17433-composer-expanded-on-cancel
branch
from
c6a7cb5 to
99250ea
Compare
|
Hi @clauxx, thanks for your PR I noticed an issue when trying to edit or reply, that the composer does not animate smoothly. Notice if the composer is blurred and then when trying to focus it animates smoothly. But when trying to edit a message the composer moves up suddenly IMG_0.3.MOV |
@OmarBasem Tried to smooth it out a bit, as it looked a bit worse when the input changed size, but the issue seems to not be related to this PR, as that was the case before it as well. This happens when focusing the input imperatively with the ref, as you can notice when replying to a message as well. We should have another issue for this, which would fix it everywhere we focus imperatively. Also, added another fix to a bug I noticed, where the input had the wrong height after canceling edit. |
@clauxx is there an open issue for that? |
|
@OmarBasem Now it seems to animate fine 🤷 Simulator.Screen.Recording.-.iPhone.11.Pro.-.2023-11-06.at.13.03.24.mp4 |
Okay good :) Good work 🚀 |
78% of end-end tests have passedFailed tests (6)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (35)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
|
|
@clauxx thank you for your work and logging these issues. Please take a look at the issue related to this PR. ISSUE 1 Mention turns into public key when editing a message containing mentionSteps:
Actual result: mention turns into public key telegram-cloud-document-2-5352944957936122007.mp4Expected result: mention does not turn into pub key |
|
Found one regression issue that wasn't captured before: ISSUE 6: edited message content in composer is reset when you re-open the chatSteps:
Expected result: Actual result: FILE.2023-11-15.17.52.01.mp4OS: IOS, Android The issue is not reproducible with the current nightly. FILE.2023-11-15.17.51.29.mp4 |
clauxx
force-pushed
the
17433-composer-expanded-on-cancel
branch
from
89e9eba to
97e7d46
Compare
|
@churik @pavloburykh @OmarBasem Fixed issue 6 and (hopefully) issue 1 is also fixed. It's a bit difficult to reproduce cause it was happening kinda randomly, but couldn't reproduce it at all after the fix. Additionally, noticed there was an issue with hiding the keyboard when closing a reply, similar to what we had here. Dealt with it here cause it was a quick fix. @ibrkhalil There was a release blocker issue here for which I needed changes from your PR, so I merged it here to make the QA process quicker. Hope that's fine by you And lastly, remembered that this PR also fixed another composer issue: #17361 |
|
@clauxx @ibrkhalil #17361 video: FILE.2023-11-16.17.42.12.mp4ISSUE 1 video: FILE.2023-11-16.17.43.22.mp4both issues are very nice to fix, but not critical for PR. I can create them separately and we'll fix it in the next release, what do you think? |
|
@churik yepp, i guess i musunderstood the first one with the composer height. The issue 1 is weird, i think it makes sense to fix them separately. Can you assign them to me please? |
|
Please, cherry-pick your commit in release branch too. |
|
@clauxx can you cherry-pick it to release branch? |
|
@churik on it. Have some issue with my GPG keys that I'm trying to fix since an hour, so can't push the cherry-picked commit. Will check with Andrea if he can do the cherrypicking on his side. |
* fix: composer height when entering and canceling edit * fix: blur the composer input when canceling edit * fix: focusing animation and composer height after blur * fix: input height when canceling edit while unfocused * ref: removed arbitrary keyboard check * fix: moved edit-mentions logic to use-edit to fix unresolved mention * fix: composer edit should put the cursor at the end * fix: (potentially) fixing the mention not resolved during edit * fix: emoji-kb handler changing the height when default kb appears * Fix text content when editing and reentering chat * prevent composer when focusing on opening chat with edit/reply * clean * Clauxx comments * Apply for reply * Lintil soup = yummy * refactor variable name * Extract the focusing logic from the data setting logic * Edge case * fix: composer mention key & edit re-enter issues * fix: reply cancel input blur and smooth reply focus --------- Co-authored-by: Ibrkhalil <[email protected]>
|
@churik it's done! |
* fix: composer height when entering and canceling edit * fix: blur the composer input when canceling edit * fix: focusing animation and composer height after blur * fix: input height when canceling edit while unfocused * ref: removed arbitrary keyboard check * fix: moved edit-mentions logic to use-edit to fix unresolved mention * fix: composer edit should put the cursor at the end * fix: (potentially) fixing the mention not resolved during edit * fix: emoji-kb handler changing the height when default kb appears * Fix text content when editing and reentering chat * prevent composer when focusing on opening chat with edit/reply * clean * Clauxx comments * Apply for reply * Lintil soup = yummy * refactor variable name * Extract the focusing logic from the data setting logic * Edge case * fix: composer mention key & edit re-enter issues * fix: reply cancel input blur and smooth reply focus --------- Co-authored-by: Ibrkhalil <[email protected]>
fixes #17433
fixes #17825
Summary
Fixed issues:
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready