feat: transaction confirmation page ui #17812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (48)
|
J-Son89
reviewed
Nov 3, 2023
src/status_im2/contexts/wallet/send/transaction_confirmation/view.cljs
Outdated
Show resolved
Hide resolved
briansztamfater
force-pushed
the
feat/select-asset-ui
branch
3 times, most recently
from
efd5cb3 to
5c8a1b2
Compare
briansztamfater
force-pushed
the
feat/select-asset-ui
branch
3 times, most recently
from
ccbf998 to
a10a1ac
Compare
briansztamfater
force-pushed
the
feat/transaction-confirmation-ui
branch
from
0a461e0 to
197204e
Compare
briansztamfater
force-pushed
the
feat/select-asset-ui
branch
from
5d05271 to
914285a
Compare
briansztamfater
force-pushed
the
feat/transaction-confirmation-ui
branch
from
197204e to
b322a24
Compare
briansztamfater
changed the title
briansztamfater
requested review from
tumanov-alex,
smohamedjavid,
J-Son89,
OmarBasem and
ulisesmac
ulisesmac
reviewed
Nov 17, 2023
Comment on lines
+29
to
+44
| {:style {:flex-direction :row | ||
| :margin-top 4}} | ||
| [quo/text | ||
| {:size :heading-1 | ||
| :weight :semi-bold | ||
| :style style/title-container | ||
| :accessibility-label :send-label} | ||
| (i18n/label :t/from)] | ||
| [quo/summary-tag | ||
| {:label "Collectibles vault" | ||
| :type :account | ||
| :emoji "🍑" | ||
| :customization-color :purple}]] | ||
| [rn/view | ||
| {:style {:flex-direction :row | ||
| :margin-top 4}} |
There was a problem hiding this comment.
These and other style maps can be moved to the style ns
src/status_im2/contexts/wallet/send/transaction_confirmation/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im2/contexts/wallet/send/transaction_confirmation/view.cljs
Outdated
Show resolved
Hide resolved
OmarBasem
approved these changes
Nov 17, 2023
src/status_im2/contexts/wallet/send/transaction_confirmation/view.cljs
Outdated
Show resolved
Hide resolved
briansztamfater
force-pushed
the
feat/select-asset-ui
branch
from
1e92732 to
38789fb
Compare
briansztamfater
force-pushed
the
feat/transaction-confirmation-ui
branch
from
63519c7 to
d4aee2b
Compare
qoqobolo
force-pushed
the
feat/select-asset-ui
branch
from
8f0e4eb to
21f3f1c
Compare
briansztamfater
force-pushed
the
feat/select-asset-ui
branch
from
21f3f1c to
af4ad5f
Compare
briansztamfater
force-pushed
the
feat/transaction-confirmation-ui
branch
2 times, most recently
from
a0f2c7f to
37fc282
Compare
ulisesmac
approved these changes
Dec 1, 2023
85% of end-end tests have passedFailed tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (41)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
|
briansztamfater
force-pushed
the
feat/transaction-confirmation-ui
branch
from
37fc282 to
90166e8
Compare
|
@briansztamfater I believe this should go through design review, as there is no flow to actually test - only one screen
|
J-Son89
reviewed
Dec 6, 2023
| [transaction-from status-account-props theme] | ||
| [transaction-to user-props theme] | ||
| [transaction-details theme] | ||
| [rn/view {:style style/slide-button-container} |
There was a problem hiding this comment.
a nit here, we should instead use container-style prop on the actual component because it is much easier to read imo.
also here we should be using slide-button from status-im2.common.standard-authentication.core instead as this will handle the auth flows 👍 -
It's a follow up anyway and the UI will be the same 👍
There was a problem hiding this comment.
Yes, I replaced it on the PR with with backend integration. Will merge this first and replace it shortly with the integration part ✨
Francesca-G
approved these changes
Dec 6, 2023
Will create an issue to fix this as we need to first make modification to our navigation component. Thanks for the review! |
briansztamfater
force-pushed
the
feat/transaction-confirmation-ui
branch
2 times, most recently
from
178ec4d to
56a78c1
Compare
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
feat/transaction-confirmation-ui
branch
from
56a78c1 to
fd0a23e
Compare
yevh-berdnyk
pushed a commit
that referenced
this pull request
Dec 8, 2023
Signed-off-by: Brian Sztamfater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16932
Summary
This PR implements transaction confirmation page UI with mocked data, backend integration to send transaction is pending as well as show transaction real data (estimated fees / duration / from data / to data).
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready