-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback/default dimensions for Image sent from desktop #17966
Conversation
Jenkins Builds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alwx, Thank you for fixing this.
Detect image dimensions correctly
We still are not detecting image dimensions correctly, we are just adding fallback. Maybe a more relevant title would be "Add fallback/default dimensions for Image sent from desktop"
Also, once status-im/status-desktop#10944 is merged, we can revert these changes. |
@Parveshdhull I don't think those changes need to be reverted even after the desktop changes are merged — it's good to have a fallback anyway just because we cannot ever be sure in other clients. |
I checked it manually, worked for me, waiting for e2e - for some reason it fails on upload APK for testing. Restarted that manually |
the issue with upload APK is not on the PR side, can merge and cherry-pick the PR to release branch, thank you! |
db83f4b
to
671aa67
Compare
Fixes #17956
Uses fallback values for dimensions because
image-width
andimage-height
are not always available which is the reason for images to be displayed incorrectly or not displayed at all.Platforms
Areas that maybe impacted
Functional
status: ready