[#17986] feat: implement new settings ui, preparation part #17991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (47)
|
|
@pedro-et shouldn’t the ‘legacy settings’ option be at the bottom of this screen, under ‘Advanced’? |
mohsen-ghafouri
force-pushed
the
refactor/profile-header
branch
2 times, most recently
from
bb508b2 to
13b8e73
Compare
mohsen-ghafouri
changed the title
mohsen-ghafouri
requested review from
J-Son89,
flexsurfer,
ilmotta and
smohamedjavid
mohsen-ghafouri
commented
Nov 27, 2023
mohsen-ghafouri
force-pushed
the
refactor/profile-header
branch
from
13b8e73 to
852ec9e
Compare
J-Son89
reviewed
Nov 27, 2023
ilmotta
reviewed
Nov 27, 2023
src/status_im2/contexts/profile/settings/header/header_shape.cljs
Outdated
Show resolved
Hide resolved
Confirmed with Pedro, Done |
ilmotta
approved these changes
Nov 27, 2023
mohsen-ghafouri
force-pushed
the
refactor/profile-header
branch
from
71886f5 to
f60a23a
Compare
|
Hey @status-im/mobile-qa this is a new profile screen and i just linked from top navigation bar. this PR is part 1 of implementation , shall i merge it after E2E test and do the QA and design review in next part #17393 ? |
flexsurfer
requested changes
Nov 28, 2023
27% of end-end tests have passedFailed tests (29)Click to expandClass TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Passed tests (12)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
|
|
@flexsurfer I can either bypass the design system and use category item directly within my flat-list, or we can stick to the current approach since this is a small static list and performance issue shouldn't be visible/valid here IMO |
mohsen-ghafouri
force-pushed
the
refactor/profile-header
branch
from
f60a23a to
0e56b52
Compare
84% of end-end tests have passedFailed tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (38)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
|
There was a problem hiding this comment.
Nice work! @mohsen-ghafouri 🚀
I found out that we didn't link the navigation header to this new profile UI. Any reason for it?
|
@smohamedjavid thanks for reviewing this, at first i linked top bar avatar to the new profile but it will drop e2e coverage as this PR still is in progress. will connect to new UI in next PR #17393 |
mohsen-ghafouri
force-pushed
the
refactor/profile-header
branch
from
0e56b52 to
4850c30
Compare
mohsen-ghafouri
force-pushed
the
refactor/profile-header
branch
from
4850c30 to
2349881
Compare
|
@mohsen-ghafouri seems something is wrong with e2e here - some changes required. I can take a look during the day. |
82% of end-end tests have passedFailed tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (5)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Passed tests (37)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
|
@mohsen-ghafouri is it expected that in Also note that in PR that will introduce the new Profile, a e2e framework has to be modified, so it will take some time. |
|
@churik, yes, as I mentioned earlier in the chat, this PR is only the beginning. The full implementation will be completed in the next PR [#17393]. Once the screen is fully developed, I'll establish the link to the new profile UI. We can also make the necessary modifications to the e2e tests in that subsequent PR. |
|
Thank you, ready to be merged! |
mohsen-ghafouri
force-pushed
the
refactor/profile-header
branch
3 times, most recently
from
64f87db to
a1a6f80
Compare
mohsen-ghafouri
force-pushed
the
refactor/profile-header
branch
from
a1a6f80 to
1533a10
Compare
yevh-berdnyk
pushed a commit
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17986
Summary
Implement new settings ui, preparation part.
will finalize logic and full design match in #17393
Before and after screenshots comparison
Dark
Light
Video
Simulator.Screen.Recording.-.iPhone.13.-.2023-11-27.at.17.18.00.mp4
status: ready