Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't restrict Diawi upload for iOS release builds #18016

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Don't restrict Diawi upload for iOS release builds #18016

merged 1 commit into from
Nov 28, 2023

Conversation

siddarthkay
Copy link
Contributor

This PR removes the restriction of uploading iOS release builds to Diawi

Summary

Its helpful to have app uploaded to Diawi to test release builds on our iPhones.
The installer is very straightforward and makes life easier.

I don't know why we restricted this before.

status: ready

@siddarthkay siddarthkay self-assigned this Nov 28, 2023
@siddarthkay siddarthkay requested a review from jakubgs as a code owner November 28, 2023 15:25
@siddarthkay siddarthkay force-pushed the lets-diwai-ios-release-builds branch from 2e144f7 to a20b7fd Compare November 28, 2023 15:25
@status-im-auto
Copy link
Member

status-im-auto commented Nov 28, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a20b7fd #2 2023-11-28 15:32:43 ~6 min android 🤖apk 📲
✔️ a20b7fd #2 2023-11-28 15:33:47 ~7 min android-e2e 🤖apk 📲
✔️ a20b7fd #2 2023-11-28 15:37:45 ~11 min tests 📄log
✔️ a20b7fd #2 2023-11-28 15:39:59 ~14 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 08a5011 #3 2023-11-28 16:38:43 ~7 min ios 📱ipa 📲
✔️ 08a5011 #3 2023-11-28 16:38:51 ~7 min android-e2e 🤖apk 📲
✔️ 08a5011 #3 2023-11-28 16:38:56 ~7 min android 🤖apk 📲
✔️ 08a5011 #3 2023-11-28 16:49:08 ~17 min tests 📄log
✔️ dbea7a9 #4 2023-11-28 17:09:54 ~12 min ios 📱ipa 📲
✔️ dbea7a9 #4 2023-11-28 17:11:03 ~13 min android 🤖apk 📲
✔️ dbea7a9 #4 2023-11-28 17:14:56 ~17 min tests 📄log
✔️ dbea7a9 #4 2023-11-28 17:15:38 ~17 min android-e2e 🤖apk 📲

@churik
Copy link
Member

churik commented Nov 28, 2023 •
edited
Loading

as far as I remember we couldn't install it from diawi because of the release type.
We also can't install it from ipa - only from testflight.
Have you tried to install release build from this PR?
Also I'm not quite sure how we're supposed to test this change.
@siddarthkay

@siddarthkay siddarthkay force-pushed the lets-diwai-ios-release-builds branch from a20b7fd to 08a5011 Compare November 28, 2023 16:31
@siddarthkay
Copy link
Contributor Author

Have you tried to install release build from this PR?

PR builds worked on my iPhone that was registered in apple developer portal.

I am not sure about release iOS builds, I think to find that out we'll first have to merge this PR and then once new nightly is generated we can try that one out ?

any other way to do this cc @jakubgs ?

@status-im-auto
Copy link
Member

84% of end-end tests have passed

Total executed tests: 45
Failed tests: 3
Expected to fail tests: 4
Passed tests: 38

IDs of failed tests: 703133,702957,702948 

IDs of expected to fail tests: 702732,703503,702731,702808

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Tap on found: SendMessageButton
    # STEP: Checking unread indicators

    activity_center/test_activity_center.py:411: in test_activity_center_mentions
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(120)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect contacts number restored: 0 instead of 2
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]
    Device 2: Looking for a message by text: it is just a message text 

    critical/chats/test_public_chat_browsing.py:1045: in test_community_hashtag_links_to_community_channels
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Receiver was not navigated to the cats channel



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (38)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    @siddarthkay
    don't restrict diawi upload for iOS release builds
    dbea7a9 
    This commit removes the restriction of uploading iOS release builds to Diawi

Its helpful to have the status app uploaded to Diawi to test release builds on our iPhones.

The installer is very straightforward and makes life easier when we want to try out release builds.
    @siddarthkay siddarthkay force-pushed the lets-diwai-ios-release-builds branch from 08a5011 to dbea7a9 Compare November 28, 2023 16:57
    @siddarthkay siddarthkay merged commit 58d5c3d into develop Nov 28, 2023
    @siddarthkay siddarthkay deleted the lets-diwai-ios-release-builds branch November 28, 2023 17:17
    siddarthkay added a commit that referenced this pull request Nov 30, 2023
    @siddarthkay
    don't restrict diawi upload for iOS release builds (#18016)
    a9e13f5 
    This commit removes the restriction of uploading iOS release builds to Diawi

Its helpful to have the status app uploaded to Diawi to test release builds on our iPhones.

The installer is very straightforward and makes life easier when we want to try out release builds.
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @siddarthkay @yevh-berdnyk
    don't restrict diawi upload for iOS release builds (#18016)
    d77aa34 
    This commit removes the restriction of uploading iOS release builds to Diawi

Its helpful to have the status app uploaded to Diawi to test release builds on our iPhones.

The installer is very straightforward and makes life easier when we want to try out release builds.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jakubgs jakubgs jakubgs approved these changes

    @FFFra FFFra FFFra approved these changes

    Assignees

    @siddarthkay siddarthkay

    Labels
    build
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @siddarthkay @status-im-auto @churik @jakubgs @FFFra