Share community channel qr code #18807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (127)
|
clauxx
requested changes
Feb 14, 2024
src/quo/components/share/share_community_channel_qr_code/schema.cljs
Outdated
Show resolved
Hide resolved
src/quo/components/share/share_community_channel_qr_code/view.cljs
Outdated
Show resolved
Hide resolved
src/quo/components/share/share_community_channel_qr_code/view.cljs
Outdated
Show resolved
Hide resolved
src/quo/components/share/share_community_channel_qr_code/view.cljs
Outdated
Show resolved
Hide resolved
src/quo/components/share/share_community_channel_qr_code/view.cljs
Outdated
Show resolved
Hide resolved
src/quo/components/share/share_community_channel_qr_code/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/wallet/share_community_channel/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/wallet/share_community_channel/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
src/quo/components/share/share_community_channel_qr_code/style.cljs
Outdated
Show resolved
Hide resolved
clauxx
reviewed
Feb 14, 2024
clauxx
reviewed
Feb 14, 2024
src/quo/components/share/share_community_channel_qr_code/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
src/quo/components/share/share_community_channel_qr_code/view.cljs
Outdated
Show resolved
Hide resolved
clauxx
reviewed
Feb 14, 2024
src/quo/components/share/share_community_channel_qr_code/view.cljs
Outdated
Show resolved
Hide resolved
|
@Pau1fitz hi! can it be retested? |
|
@mariia-skrypnyk, yes I believe it can be retested now 👍 |
|
sorry @mariia-skrypnyk, can confirm it can be retested |
|
Found several issues. Steps:
ISSUE 3: QR code looks not as designed Actual result:
Expected result: Screen looks as designed |
|
ISSUE 4: Nothing happens when users scans channel QR-code Steps:
Actual result: nothing happens IMG_6919.MP4Expected result: exact community should be opened |
HI @mariia-skrypnyk - can you try with a regular scanner? I think that is related to the Status QA scanner actually 👍 |
hmm, I think in this case it might be the following. boarder color - the border color is dependent on the channel color - so it seems right unless the channel has the same color as the one you shared. Need to test with a community channel which has a color that's a bit more distinct than the background. white boarder width - this is a separate issue which needs to be addressed on the Quo QR component 👍 size and font color - I checked with Figma and this looked correct to me. Perhaps it's because you are verifying with android? I will check the code and design directly now too 👍 Edit: |
J-Son89
reviewed
Feb 20, 2024
| (let [{:keys [url chat-id]} (rf/sub [:get-screen-params]) | ||
| {:keys [color emoji chat-name]} (rf/sub [:chats/community-channel-ui-details-by-id chat-id]) | ||
| window-width (rf/sub [:dimensions/window-width])] | ||
| (prn color emoji chat-name chat-id) |
There was a problem hiding this comment.
can you remove this print statement btw @Pau1fitz ?
|
@J-Son89 @mariia-skrypnyk updated based on the feedback |
Hi @J-Son89! Thanks for your involving into this issue. cc @Pau1fitz |
Thank you both! Now PR is fully tested and I move it to the design review approve by @Francesca-G ! |
|
Great, thanks @mariia-skrypnyk! - Just a heads up about the scanner, @alwx is working on something related to that and there might already be issues created for it. Please align with him as he will know. He recently developed the first part of the generic scanner but there is a lot of functionality to be added, community channels being one of them 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17993
Figma design here.
Screen.Recording.2024-02-13.at.17.39.22.mov
iOS
Android
Testing notes:
Navigate to an communities screen
choose a community
or