chore: improve android & iOS build step #18900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
|
@siddarthkay finally worked 🚀 Btw I noticed the android build took longer than usual, about 10 minutes |
hmm thats because its a nix build inside a sandbox. I'll try to improve speed of debug builds in the future. |
siddarthkay
force-pushed
the
get-rid-of-nohup
branch
from
420f19b to
a60508b
Compare
vkjr
approved these changes
Feb 19, 2024
jakubgs
approved these changes
Feb 19, 2024
siddarthkay
force-pushed
the
get-rid-of-nohup
branch
from
a60508b to
03fb843
Compare
siddarthkay
force-pushed
the
get-rid-of-nohup
branch
from
03fb843 to
ec1f34d
Compare
7 tasks
@siddarthkay so yesterday and today I have built the app multiple times and every time it takes 10 minutes to build |
|
Obviously Nix would rebuild the derivation if the source code changes. |
Compared to a week before, the android build would take 2-3 minutes when there is code changes |
|
Probably something that should be cached in the build process that is no longer being cached in the recent changes. |
|
Nothing is being cached between Nix builds other than dependencies and tooling. |
I'll log this as an issue and will think of possible solutions there. |
From the logs I see, it seems to me that it rebuilds the dependencies everytime |
Btw I tested building 2 times in a row without any code changes and it takes 10 minutes for both builds |
|
Not related to this issue. The thing that
in the past. Is it status-go react native module triggered by yarn install? |
siddarthkay
added a commit
that referenced
this pull request
Feb 24, 2024
fixes #18915 ## Summary In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 24, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 24, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 24, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 24, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 24, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
ibrkhalil
pushed a commit
that referenced
this pull request
Feb 25, 2024
fixes #18888 ## Summary `make run-android` was sometimes flaky because we used to send metro to background via `nohup` and then bring it back to foreground after we read metro logs. Now we do not send metro to background. We first wait for a successful build. we then install the app on the simulator. After this is done we give command to sleep until metro server has started, Once metro server has started we open the installed app. In this workflow the command to open the installed app goes in background and metro stays in foreground. The new workflow should now be less flaky. ## Review notes `make run-clojure` `make run-android` OR `make run-ios` should just work #### Platforms - Android - iOS
siddarthkay
added a commit
that referenced
this pull request
Feb 26, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 26, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 26, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 27, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 27, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 27, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
added a commit
that referenced
this pull request
Feb 27, 2024
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
Its probably the runtime |
created issue to track -> #19081 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18888
Summary
make run-androidwas sometimes flaky because we used to send metro to background vianohupand then bring it back to foreground after we read metro logs.Now we do not send metro to background.
The new workflow should now be less flaky.
Review notes
make run-clojuremake run-androidORmake run-iosshould just workPlatforms
status: ready