Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Enable Test Networks by default on E2E and PR builds #19365

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[Feature] Enable Test Networks by default on E2E and PR builds #19365

merged 1 commit into from
Mar 26, 2024

Conversation

smohamedjavid
Copy link
Member

fixes #19347

Summary

This PR enables Test Networks in E2E and PR Builds by default and disables in Release/Nightly Builds.

status-go PR: status-im/status-go#4971

Platforms

  • Android
  • iOS

status: ready

@smohamedjavid smohamedjavid requested review from qfrank and a team March 22, 2024 11:22
@smohamedjavid smohamedjavid self-assigned this Mar 22, 2024
@smohamedjavid smohamedjavid requested a review from jakubgs as a code owner March 22, 2024 11:22
qfrank
qfrank reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@qfrank qfrank left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want enable it for local dev build? i mean no changes to .env? @smohamedjavid

@status-im-auto
Copy link
Member

status-im-auto commented Mar 22, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (20)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 08f2299 #1 2024-03-22 11:31:16 ~8 min tests 📄log
✔️ 08f2299 #1 2024-03-22 11:31:29 ~8 min android 🤖apk 📲
✔️ 08f2299 #1 2024-03-22 11:31:56 ~8 min android-e2e 🤖apk 📲
✔️ 8dd7f38 #2 2024-03-22 11:52:15 ~7 min tests 📄log
✔️ 8dd7f38 #2 2024-03-22 11:52:17 ~7 min android-e2e 🤖apk 📲
✔️ 8dd7f38 #2 2024-03-22 11:52:50 ~7 min android 🤖apk 📲
✔️ 8dd7f38 #2 2024-03-22 11:56:27 ~11 min ios 📱ipa 📲
✔️ e16938d #3 2024-03-25 10:08:26 ~8 min android-e2e 🤖apk 📲
✔️ e16938d #3 2024-03-25 10:08:32 ~8 min tests 📄log
✔️ e16938d #3 2024-03-25 10:08:49 ~8 min android 🤖apk 📲
✔️ e16938d #3 2024-03-25 10:15:55 ~15 min ios 📱ipa 📲
✔️ 1ee816f #4 2024-03-26 11:49:51 ~7 min android-e2e 🤖apk 📲
✔️ 1ee816f #4 2024-03-26 11:50:50 ~8 min android 🤖apk 📲
✔️ 1ee816f #4 2024-03-26 11:54:01 ~11 min ios 📱ipa 📲
✔️ 44830f3 #6 2024-03-26 12:10:41 ~7 min android 🤖apk 📲
✔️ 44830f3 #6 2024-03-26 12:10:49 ~7 min android-e2e 🤖apk 📲
✔️ 44830f3 #6 2024-03-26 12:14:36 ~11 min ios 📱ipa 📲
✔️ 84f361f #7 2024-03-26 12:36:41 ~6 min android-e2e 🤖apk 📲
✔️ 84f361f #7 2024-03-26 12:38:06 ~7 min android 🤖apk 📲
✔️ 84f361f #7 2024-03-26 12:40:56 ~10 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 833616c #8 2024-03-26 14:45:52 ~6 min android-e2e 🤖apk 📲
✔️ 833616c #8 2024-03-26 14:45:59 ~6 min android 🤖apk 📲
✔️ 833616c #8 2024-03-26 14:49:04 ~9 min ios 📱ipa 📲
✔️ e52567e #9 2024-03-26 15:22:22 ~8 min android 🤖apk 📲
✔️ e52567e #9 2024-03-26 15:23:31 ~9 min android-e2e 🤖apk 📲
✔️ e52567e #12 2024-03-26 15:23:44 ~9 min tests 📄log
✔️ e52567e #9 2024-03-26 15:23:45 ~9 min ios 📱ipa 📲

@smohamedjavid
Copy link
Member Author

we don't want enable it for local dev build? i mean no changes to .env? @smohamedjavid

@qfrank - Nice to have. I made changes as per the Issue. There's no harm in enabling it on Dev builds. I will add it 👍

@smohamedjavid smohamedjavid force-pushed the feature/enable-test-net-by-default-on-e2e-and-pr-builds branch from 08f2299 to 8dd7f38 Compare March 22, 2024 11:44
qfrank
qfrank approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@qfrank qfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your PR

@smohamedjavid smohamedjavid force-pushed the feature/enable-test-net-by-default-on-e2e-and-pr-builds branch from 8dd7f38 to e16938d Compare March 25, 2024 10:00
@smohamedjavid smohamedjavid mentioned this pull request Mar 25, 2024
Closed
@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

IDs of failed tests: 703495,703629 

IDs of expected to fail tests: 703503

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Looking for community: 'open community'
    Device 2: Click until `Text` by `accessibility id`: `community-description-text` will be presented 

    critical/chats/test_public_chat_browsing.py:1180: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:491: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chat name is not shown after unmute
E    Message text 'Chat is unmuted now' is not shown in chat preview after unmute



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (45)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    @yevh-berdnyk yevh-berdnyk self-assigned this Mar 25, 2024
    @yevh-berdnyk
    Copy link
    Contributor

    Hi @smohamedjavid
    Thanks for this PR, everything looks good for me!

    @smohamedjavid smohamedjavid force-pushed the feature/enable-test-net-by-default-on-e2e-and-pr-builds branch 5 times, most recently from 84f361f to 833616c Compare March 26, 2024 14:39
    @smohamedjavid smohamedjavid force-pushed the feature/enable-test-net-by-default-on-e2e-and-pr-builds branch from 833616c to e52567e Compare March 26, 2024 15:13
    @smohamedjavid smohamedjavid merged commit 1d44472 into develop Mar 26, 2024
    6 checks passed
    @smohamedjavid smohamedjavid deleted the feature/enable-test-net-by-default-on-e2e-and-pr-builds branch March 26, 2024 15:25
    mmilad75 pushed a commit that referenced this pull request Apr 2, 2024
    @smohamedjavid @mmilad75
    [Feature] Enable Test Networks by default on Dev, E2E and PR builds (#…
    7ac746c 
    …19365)

status-im/status-go@eb13459...158bd70

This commit enables Test Networks in Dev, E2E and PR Builds by default and disables in Release/Nightly Builds.

This enables in create account or restore account flow. If you upgrade the app from the old build with an existing profile, it will use the last saved (test networks enabled) state of that profile.

Signed-off-by: Mohamed Javid <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jakubgs jakubgs jakubgs approved these changes

    @qfrank qfrank qfrank approved these changes

    @ulisesmac ulisesmac ulisesmac approved these changes

    Assignees

    @smohamedjavid smohamedjavid

    @yevh-berdnyk yevh-berdnyk

    Labels
    request-manual-qa status-go Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Enable Testnet mode by default in e2e/PR builds
    6 participants
    @smohamedjavid @status-im-auto @yevh-berdnyk @jakubgs @qfrank @ulisesmac