e2e: wallet tests added #19477
Merged
e2e: wallet tests added #19477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (18)
|
yevh-berdnyk
force-pushed
the
tests/wallet-tests
branch
from
396bf71 to
d303ece
Compare
90% of end-end tests have passedFailed tests (2)Click to expandClass TestWalletOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Passed tests (47)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
|
yevh-berdnyk
force-pushed
the
tests/wallet-tests
branch
from
d303ece to
c6c8622
Compare
50% of end-end tests have passedNot executed tests (48)Expected to fail tests (2)Click to expandClass TestWalletMultipleDevice:
Passed tests (2)Click to expandClass TestWalletOneDevice:
|
churik
reviewed
Apr 3, 2024
|
|
||
| # ToDo: Add verification of Activity tabs when the feature is ready in the next 2 tests: | ||
|
|
||
| def _get_balances_before_tx(self): |
There was a problem hiding this comment.
are you sure it is worth having it here, not in a separate file?
I believe it might be used in subsequent tests too?
There was a problem hiding this comment.
I'd rather leave as it is for now as it's needed only here. If we'll use in other files we can move it later
churik
reviewed
Apr 3, 2024
| self.home_2.wallet_tab.click() | ||
| new_eth_amount_receiver = self.wallet_2.get_asset(asset_name='Ether').get_amount() | ||
| exp_amount_sender = eth_amount_sender - amount_to_send | ||
| if new_eth_amount_sender > exp_amount_sender: |
There was a problem hiding this comment.
are we cure that in this place cannot be delay in updating the balance inside the app?
There was a problem hiding this comment.
Not yet, I'll add it later
| new_eth_amount_receiver, exp_amount_receiver)) | ||
| self.errors.verify_no_errors() | ||
|
|
||
| @marks.xfail(reason="Can't find routes on Sepolia https://github.com/status-im/status-mobile/issues/19473", |
There was a problem hiding this comment.
would be nice to check if it passed on #19483, thanks!
| self.errors.verify_no_errors() | ||
|
|
||
| @marks.testrail_id(727232) | ||
| def test_wallet_add_remove_watch_only_account(self): |
There was a problem hiding this comment.
may be we can add some interesting account here and check collectibles, some unusual assets etc.
Can be done later I believe
There was a problem hiding this comment.
Totally agree, but it seems that not all the functionality is ready yet.
| except JSONDecodeError as e: | ||
| self.log("No valid JSON response from Etherscan: %s " % str(e)) | ||
| pass | ||
| time.sleep(30) |
There was a problem hiding this comment.
I do not exactly remember why we had it here, it might be due to some limitation on etherscan API. Are you sure that we need to remove it?
There was a problem hiding this comment.
We can add it anytime. For now I decided not to use it because of the time limits. Current api key limits should be enough for current amount of requests
yevh-berdnyk
force-pushed
the
tests/wallet-tests
branch
2 times, most recently
from
23f1b1a to
ef6d1e2
Compare
75% of end-end tests have passedFailed tests (1)Click to expandClass TestWalletMultipleDevice:
Passed tests (3)Click to expandClass TestWalletOneDevice:
Class TestWalletMultipleDevice:
|
churik
approved these changes
Apr 4, 2024
yevh-berdnyk
force-pushed
the
tests/wallet-tests
branch
from
ef6d1e2 to
e532d7d
Compare
100% of end-end tests have passedPassed tests (4)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
|
yevh-berdnyk
force-pushed
the
tests/wallet-tests
branch
from
e532d7d to
918b98e
Compare
yevh-berdnyk
force-pushed
the
tests/wallet-tests
branch
from
918b98e to
5bff89a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.