e2e: updating PR pipeline #19478
Merged
e2e: updating PR pipeline #19478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (4)
|
pavloburykh
approved these changes
Apr 2, 2024
VolodLytvynenko
approved these changes
Apr 2, 2024
qoqobolo
approved these changes
Apr 2, 2024
doc/pipeline_process.md
Outdated
|
|
||
| ### Adding `skip-manual-qa` | ||
|
|
||
| - Please ask another team member before adding the `skip-manual-qa` label (or here in chat) so that there's a second opinion. |
There was a problem hiding this comment.
(or here in chat)
looks like it should be (or on Discord/Status community/DMs) or smth like that instead
doc/pipeline_process.md
Outdated
| Information on how to analyze tests can be found [here](https://github.com/status-im/status-mobile/blob/develop/doc/how-to-launch-e2e.md). | ||
| Tests might be flaky, as they depend on infrastructure - SauceLabs and Waku. | ||
|
|
||
| If there are `Failed tests` and you are not sure about the reason, you can always ping the mobile QAs for help (preferably in PRs). |
There was a problem hiding this comment.
I think you can also mention here that devs should use our group tag @status-im/mobile-qa in this case
yevh-berdnyk
approved these changes
Apr 2, 2024
Samyoul
reviewed
Apr 2, 2024
doc/pipeline_process.md
Outdated
| 4. Has the label: `request-manual-qa` | ||
| 1. Reviewed and has at least 1 approval. | ||
| 2. Rebased to the `develop` branch (both `status-mobile` and `status-go` if needed, depending on what part has changes). | ||
| - **NOTE:** QAs can use the `Update with rebase` button from GitHub in case if: |
There was a problem hiding this comment.
Minor grammatical thing
Suggested change
| - **NOTE:** QAs can use the `Update with rebase` button from GitHub in case if: | |
| - **NOTE:** QAs can use the `Update with rebase` button from GitHub if: |
or
Suggested change
| - **NOTE:** QAs can use the `Update with rebase` button from GitHub in case if: | |
| - **NOTE:** QAs can use the `Update with rebase` button from GitHub in case of: |
Samyoul
reviewed
Apr 2, 2024
doc/pipeline_process.md
Outdated
| ### Adding `skip-manual-qa` | ||
|
|
||
| - Please ask another team member before adding the `skip-manual-qa` label (or here in chat) so that there's a second opinion. | ||
| - The PR should have a proper reasoning why manual QA is skipped. |
There was a problem hiding this comment.
Suggested change
| - The PR should have a proper reasoning why manual QA is skipped. | |
| - The PR MUST have a proper reasoning why manual QA is skipped. |
Samyoul
reviewed
Apr 2, 2024
doc/pipeline_process.md
Outdated
|
|
||
| - Please ask another team member before adding the `skip-manual-qa` label (or here in chat) so that there's a second opinion. | ||
| - The PR should have a proper reasoning why manual QA is skipped. | ||
| - The PR should include the steps of testing that has been done by the developer prior to moving it forward. |
There was a problem hiding this comment.
I don't know if this one needs to be a MUST, but I've suggested it
Suggested change
| - The PR should include the steps of testing that has been done by the developer prior to moving it forward. | |
| - The PR MUST include the steps of testing that has been done by the developer prior to moving it forward. |
Samyoul
reviewed
Apr 2, 2024
doc/pipeline_process.md
Outdated
| **From the perspective of a developer it means that once work on PR is finished:** | ||
|
|
||
| 1. It should be rebased to the latest `develop`. If there are conflicts - they should be resolved if possible. | ||
| 2. If the PR was in the `Contributor` column - it should be moved to `Review` column. | ||
| 3. Wait for the review. | ||
| 4. Make sure that after review and before requesting manual QA your PR is rebased to current develop. | ||
| 5. Once the PR has been approved by reviewer(s) - label `request-manual-qa` should be applied to the PR | ||
| 6. Move PR to the E2E column when it is ready for testing (**mandatory for all PRs**). That will also trigger e2e tests run. QAs are monitoring PRs from E2E column and take it into test. | ||
| 6. **MUST:** Move PR to the E2E column when it is ready for testing (**mandatory for all PRs**). That will also trigger e2e tests run. QAs are monitoring PRs from E2E column and take it into test. |
There was a problem hiding this comment.
This makes more grammatical sense to me, but I also may be misunderstanding.
If the full sentence is
From the perspective of a developer it means that once work on PR is finished:
Then the below sentence makes more sense to me.
Suggested change
| 6. **MUST:** Move PR to the E2E column when it is ready for testing (**mandatory for all PRs**). That will also trigger e2e tests run. QAs are monitoring PRs from E2E column and take it into test. | |
| 6. The PR **MUST** be moved to the E2E column when it is ready for testing (**mandatory for all PRs**). That will also trigger e2e tests run. QAs are monitoring PRs from E2E column and take it into test. |
Samyoul
reviewed
Apr 2, 2024
doc/pipeline_process.md
Outdated
| @@ -68,7 +98,7 @@ There are three possible scenarios when the design review is completed: | |||
| --- | |||
|
|
|||
| #### Why my PR is in `Contributor` column? | |||
| PR can be moved to this column by the ```status-github-bot``` or by QA engineer with label `Tested-issues`. | |||
| PR can be moved to this column by the ```status-github-bot``` or by QA engineer with label `Tested-issues` or if one of the requirement for manual QA was not met. | |||
There was a problem hiding this comment.
Suggested change
| PR can be moved to this column by the ```status-github-bot``` or by QA engineer with label `Tested-issues` or if one of the requirement for manual QA was not met. | |
| PR can be moved to this column by the ```status-github-bot``` or by QA engineer with label `Tested-issues` or if one of the requirements for manual QA was not met. |
Samyoul
reviewed
Apr 2, 2024
doc/pipeline_process.md
Outdated
Comment on lines
63
to
66
| 1. PR has a description and the area affected. | ||
| 2. PR has automation results from the previous step. | ||
| 3. PR includes a demo, test steps, and possible regression | ||
| 4. PR has out of scope (if appropriate) |
There was a problem hiding this comment.
Suggested change
| 1. PR has a description and the area affected. | |
| 2. PR has automation results from the previous step. | |
| 3. PR includes a demo, test steps, and possible regression | |
| 4. PR has out of scope (if appropriate) | |
| 1. PR has a description of the change and details the area of the application affected by the change. | |
| 2. PR has automation results from the previous E2E test run step. | |
| 3. PR includes a demo, test steps, and any possible regression(s) | |
| 4. If appropriate, PR details what elements of a feature are out of scope. |
Samyoul
approved these changes
Apr 2, 2024
churik
force-pushed
the
docs/update-pipeline
branch
3 times, most recently
from
edf9e2c to
79aada9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip e2e