-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix contrast between Chats and Communities with new messages #21242
Conversation
7cb9f0f
to
79953df
Compare
Jenkins Builds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🙌
Can you include some screenshots please since these changes are mostly colour related? 🙏
Thank you @seanstrom for reviewing PR. Updated PR description with screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! thanks for the screenshots 📸, I think it looks right
Though will this be design-reviewed before merge?
79953df
to
d1c6e50
Compare
86% of end-end tests have passed
Failed tests (1)Click to expandClass TestWalletMultipleDevice:
Passed tests (6)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
|
@Parveshdhull thank you for the fix. Looks good to me. @Francesca-G would you mind checking from your side as well? Thanx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 👍
Thank you @Francesca-G @Parveshdhull PR is ready for merge now. |
fixes #21231
Screenshots
status: ready