Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix contrast between Chats and Communities with new messages #21242

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Sep 10, 2024

fixes #21231

Screenshots

1
2

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Sep 10, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 79953df #2 2024-09-10 09:43:16 ~5 min tests 📄log
✔️ 79953df #2 2024-09-10 09:45:41 ~7 min android-e2e 🤖apk 📲
✔️ 79953df #2 2024-09-10 09:46:43 ~8 min android 🤖apk 📲
✔️ 79953df #2 2024-09-10 09:50:51 ~13 min ios 📱ipa 📲
✔️ d1c6e50 #3 2024-09-16 09:57:59 ~4 min tests 📄log
✔️ d1c6e50 #3 2024-09-16 10:00:05 ~6 min android-e2e 🤖apk 📲
✔️ d1c6e50 #3 2024-09-16 10:00:22 ~6 min android 🤖apk 📲
✔️ d1c6e50 #3 2024-09-16 10:02:19 ~8 min ios 📱ipa 📲

Copy link
Member

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙌

Can you include some screenshots please since these changes are mostly colour related? 🙏

@Parveshdhull
Copy link
Member Author

Thank you @seanstrom for reviewing PR. Updated PR description with screenshots.

Copy link
Member

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks for the screenshots 📸, I think it looks right
Though will this be design-reviewed before merge?

@pavloburykh pavloburykh self-assigned this Sep 16, 2024
@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 0
Passed tests: 6
IDs of failed tests: 727229 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
    Device 2: `Text` is `0.05859 ETH`

    critical/test_wallet.py:159: in test_wallet_send_eth
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Sender balance is not updated on Etherscan, it is 0.4262 but expected to be 0.4263
    



    Passed tests (6)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @Parveshdhull thank you for the fix. Looks good to me.

    @Francesca-G would you mind checking from your side as well? Thanx.

    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice job 👍

    @pavloburykh
    Copy link
    Contributor

    Nice job 👍

    Thank you @Francesca-G

    @Parveshdhull PR is ready for merge now.

    @Parveshdhull Parveshdhull merged commit cdb2370 into develop Sep 16, 2024
    6 of 7 checks passed
    @Parveshdhull Parveshdhull deleted the fix/contrast-color branch September 16, 2024 13:43
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Lack of contrast between Chats and Communities with new messages compromises UX
    5 participants