-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore : rename crypto phrases, buy Eth and buy assets #21404
Conversation
bd9aba9
to
3f87377
Compare
Jenkins BuildsClick to see older builds (4)
|
100% of end-end tests have passed
Passed tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3f87377
to
dadff16
Compare
@mohsen-ghafouri Hello! Thanks for your PR. All looks great, but I have few questions.
|
Hi @Horupa-Olena, thanks for testing this PR, for point 1, no i didn't have any changes regarding this kind of error and it's different from Not enough asset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I'm related to these changes.
@mohsen-ghafouri Thanks for your answers. You can merge this PR, I don't see any other issues. |
dadff16
to
79609d7
Compare
fixes #21396
It closes subtasks:
Summary
rename "buy ETH" -> "Add ETH" , "Buy assets" -> "Add assets", "Buy Assets" in title -> "Ways to buy assets"
Testing notes
No code changes, only labels. please check if e2e needs any adjustment.
status: ready