Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : rename crypto phrases, buy Eth and buy assets #21404

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Oct 9, 2024

fixes #21396

It closes subtasks:

Summary

rename "buy ETH" -> "Add ETH" , "Buy assets" -> "Add assets", "Buy Assets" in title -> "Ways to buy assets"

Testing notes

No code changes, only labels. please check if e2e needs any adjustment.

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Oct 9, 2024
@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/rename-crypto-phrase branch from bd9aba9 to 3f87377 Compare October 9, 2024 09:53
@mohsen-ghafouri mohsen-ghafouri requested review from shivekkhurana, briansztamfater and ulisesmac and removed request for jakubgs October 9, 2024 09:53
@status-im-auto
Copy link
Member

status-im-auto commented Oct 9, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3f87377 #2 2024-10-09 10:00:54 ~7 min android-e2e 🤖apk 📲
✔️ 3f87377 #2 2024-10-09 10:02:22 ~8 min tests 📄log
✔️ 3f87377 #2 2024-10-09 10:03:19 ~9 min android 🤖apk 📲
✔️ 3f87377 #2 2024-10-09 10:04:29 ~11 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dadff16 #3 2024-10-11 13:22:37 ~11 min android-e2e 🤖apk 📲
✔️ dadff16 #3 2024-10-11 13:27:35 ~16 min ios 📱ipa 📲
✔️ dadff16 #4 2024-10-11 13:52:14 ~4 min tests 📄log
✔️ dadff16 #4 2024-10-11 13:54:29 ~8 min android 🤖apk 📲
✔️ 79609d7 #5 2024-10-15 09:52:04 ~4 min tests 📄log
✔️ 79609d7 #4 2024-10-15 09:53:56 ~6 min android-e2e 🤖apk 📲
✔️ 79609d7 #5 2024-10-15 09:55:21 ~8 min android 🤖apk 📲
✔️ 79609d7 #4 2024-10-15 09:57:43 ~10 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 0
Passed tests: 7

Passed tests (7)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions

2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

Copy link
Contributor

@briansztamfater briansztamfater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Horupa-Olena Horupa-Olena self-assigned this Oct 10, 2024
@Horupa-Olena Horupa-Olena force-pushed the fix/rename-crypto-phrase branch from 3f87377 to dadff16 Compare October 11, 2024 13:10
@Horupa-Olena
Copy link

@mohsen-ghafouri Hello! Thanks for your PR. All looks great, but I have few questions.

  1. Did you work on renaming the button for the collectibles send flow? I’m encountering an error that doesn’t match the design. Can this be fixed in this PR, or should I submit a separate bug report?

IMG_0015

  1. Also, are the changes only related to 'Buy ETH' and 'Buy assets'? Do we need to change 'Buy crypto' as shown on the screen?
    IMG_0016

@mohsen-ghafouri
Copy link
Contributor Author

Hi @Horupa-Olena, thanks for testing this PR, for point 1, no i didn't have any changes regarding this kind of error and it's different from Not enough asset.
for point 2, we only changed the title of modal. there wasn't any request about modal list item changes in mentioned issue's description.

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I'm related to these changes.

@Horupa-Olena
Copy link

@mohsen-ghafouri Thanks for your answers. You can merge this PR, I don't see any other issues.

@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/rename-crypto-phrase branch from dadff16 to 79609d7 Compare October 15, 2024 09:47
@mohsen-ghafouri mohsen-ghafouri merged commit 9e43aa0 into develop Oct 15, 2024
6 checks passed
@mohsen-ghafouri mohsen-ghafouri deleted the fix/rename-crypto-phrase branch October 15, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment