Skip to content

Fix error when confirming Swap #21435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

clauxx
Copy link
Member

@clauxx clauxx commented Oct 15, 2024

fixes #21406

Summary

The screen component is unmounted only after the state clean-up, leading to the .toLowerCase error in the view. To avoid any clean-up errors, we should make sure it only happens after the component is unmounted. I chose the wallet.swap.setup-swap screen, since it's the first screen in the flow that depends on the state.

Testing notes

Make sure that it works with approvals (spending caps) as well.

status: ready

@clauxx clauxx self-assigned this Oct 15, 2024
@clauxx clauxx changed the title Fix error when confirmng Swap Fix error when confirming Swap Oct 15, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Oct 15, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1659d59 #2 2024-10-15 11:46:19 ~5 min tests 📄log
✔️ 1659d59 #2 2024-10-15 11:50:27 ~9 min android-e2e 🤖apk 📲
✔️ 1659d59 #2 2024-10-15 11:50:38 ~9 min android 🤖apk 📲
✔️ 1659d59 #2 2024-10-15 11:52:31 ~11 min ios 📱ipa 📲
✔️ 5ccee71 #3 2024-10-16 05:24:27 ~5 min tests 📄log
✔️ 5ccee71 #3 2024-10-16 05:28:09 ~8 min android-e2e 🤖apk 📲
✔️ 5ccee71 #3 2024-10-16 05:28:50 ~9 min ios 📱ipa 📲
✔️ 5ccee71 #3 2024-10-16 05:28:50 ~9 min android 🤖apk 📲

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 0
Passed tests: 6
IDs of failed tests: 702843 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:420: in join_community
        self.join_button.wait_and_click(120)
    ../views/base_element.py:100: in wait_and_click
        self.wait_for_visibility_of_element(sec)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Passed tests (6)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    hi @clauxx thank you for PR. No issues from my side. PR is ready to be merged

    @shivekkhurana shivekkhurana merged commit 6a26eba into develop Oct 16, 2024
    6 checks passed
    @shivekkhurana shivekkhurana deleted the cl-21406-swap-confirmation-error branch October 16, 2024 07:57
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Status: Done
    Development

    Successfully merging this pull request may close these issues.

    Cannot read properly "toLowerCase of null" error is shown after swap transaction confirmation
    6 participants