Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix public chat deletion and name display issues post-migration #21469

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Oct 20, 2024

fixes #21153

Summary

#21153 (comment)

Acceptance criteria for this issue:

chat is shown like #name in the list instead of {"e.....th"}
can remove it via options
Optional:
header and message "Add {...} to contacts" in chat view

Fixed the first two and partially the last. It will still show as 'Add chat name to contacts' for public chats.

Video

output-2024-10-21_13.35.43.mp4

Testing Note:

Please let me know if you need assistance while testing.

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Oct 20, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
6afe969 #1 2024-10-20 14:05:30 ~3 min tests 📄log
✔️ 6afe969 #1 2024-10-20 14:08:44 ~6 min android-e2e 🤖apk 📲
✔️ 6afe969 #1 2024-10-20 14:10:16 ~7 min android 🤖apk 📲
✔️ 6afe969 #1 2024-10-20 14:12:47 ~10 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 50dffd4 #2 2024-10-20 14:36:16 ~4 min tests 📄log
✔️ 50dffd4 #2 2024-10-20 14:37:59 ~6 min android-e2e 🤖apk 📲
✔️ 50dffd4 #2 2024-10-20 14:39:37 ~7 min android 🤖apk 📲
✔️ 50dffd4 #2 2024-10-20 14:41:22 ~9 min ios 📱ipa 📲
✔️ 20339ad #3 2024-10-21 11:11:54 ~4 min tests 📄log
✔️ 20339ad #3 2024-10-21 11:15:07 ~7 min android-e2e 🤖apk 📲
✔️ 20339ad #3 2024-10-21 11:15:23 ~7 min android 🤖apk 📲
✔️ 20339ad #3 2024-10-21 11:21:17 ~13 min ios 📱ipa 📲

@Parveshdhull Parveshdhull force-pushed the fix/allow-public-chat-deletion branch from 6afe969 to 50dffd4 Compare October 20, 2024 14:31
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 0
Passed tests: 7
IDs of failed tests: 702843 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:420: in join_community
        self.join_button.wait_and_click(120)
    ../views/base_element.py:100: in wait_and_click
        self.wait_for_visibility_of_element(sec)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Passed tests (7)

    Click to expand

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    @mariia-skrypnyk mariia-skrypnyk self-assigned this Oct 21, 2024
    @mariia-skrypnyk
    Copy link

    Hi @Parveshdhull !

    Checked on Android build, works as expected.
    Amazing job as always 🙌
    E2E fail is not related to a PR.
    Fill free to merge!

    @Parveshdhull Parveshdhull force-pushed the fix/allow-public-chat-deletion branch from 50dffd4 to 20339ad Compare October 21, 2024 11:07
    @Parveshdhull Parveshdhull merged commit 020d5cc into develop Oct 21, 2024
    5 checks passed
    @Parveshdhull Parveshdhull deleted the fix/allow-public-chat-deletion branch October 21, 2024 11:21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    No way to delete public chats after migration from v1 and they are shown as {...} in chat list
    4 participants