-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci)_: bump universal apk size limit to 125MB #21486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @siddarthkay, could you just give a short explanation as to why 125MB is sufficient now and why do you think it could be sufficient in the future? How large can we make the universal APK? I guess it could be any size (?) because the Play store won't use universal APKs.
Hey @ilmotta : sure for 2.31 the release APK is 118 MB which should not grow much as long as newer assets or npm libraries are not added to the app. You're right the size of Universal APK doesn't really matter since we upload individual APKs to playstore. There is value in identifying when APK sizes grow and having this kind of check helps us identify the commits which caused the bloating of APK size which we could introspect on if we ever reach a stage where we have to cut down on APK size. |
88% of end-end tests have passed
Failed tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (7)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
|
Summary
This PR fixes 2.31 Android Release builds from failing with
Testing notes
can be skipped
Platforms
status: ready