-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Failed to get dApps" error when a session expired #21531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smohamedjavid
approved these changes
Oct 30, 2024
vkjr
approved these changes
Oct 30, 2024
Jenkins Builds
|
mohsen-ghafouri
approved these changes
Oct 30, 2024
@clauxx thanks for the PR. So far I have not faced the issue again. Let's merge and cherry pick it so we can keep an eye on this in the release. |
62% of end-end tests have passed
Failed tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Passed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
|
ilmotta
pushed a commit
that referenced
this pull request
Oct 30, 2024
* fix: pass the topic instead of entire session * chore: added logs for future debugging
ilmotta
pushed a commit
that referenced
this pull request
Oct 30, 2024
* fix: pass the topic instead of entire session * chore: added logs for future debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21530
Summary
The topic wasn't passed correctly to "wallet_disconnectWalletConnectSession", where instead we were passing the entire session map. This caused the error toast to show up when updating the "disconnected" state (status-go db) of an expired session.
Steps to test
A bit difficult to test, since you need to have a session that just expired (while the app is closed) and then open the app.
status: ready