Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation drawer on Check your Keycard screen #21997

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Jan 29, 2025

fixes #21646

RPReplay_Final1738141359.mp4

Testing note:

PR only adds a simple documentation drawer and don't need manual qa.

status: ready

@Parveshdhull Parveshdhull self-assigned this Jan 29, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Jan 29, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3810865 #1 2025-01-29 08:47:14 ~4 min tests 📄log
✔️ 3810865 #1 2025-01-29 08:49:53 ~7 min android-e2e 🤖apk 📲
✔️ 3810865 #1 2025-01-29 08:51:00 ~8 min android 🤖apk 📲
✔️ 3810865 #1 2025-01-29 08:55:01 ~12 min ios 📱ipa 📲
✔️ f25d50f #3 2025-01-29 09:15:35 ~4 min tests 📄log
✔️ f25d50f #3 2025-01-29 09:18:10 ~7 min android 🤖apk 📲
✔️ f25d50f #3 2025-01-29 09:18:20 ~7 min android-e2e 🤖apk 📲
✔️ f25d50f #3 2025-01-29 09:21:08 ~10 min ios 📱ipa 📲

@Parveshdhull Parveshdhull force-pushed the chore/documentation-drawer-for-keycard-info branch from 3810865 to 1aeb032 Compare January 29, 2025 09:07
@Parveshdhull Parveshdhull force-pushed the chore/documentation-drawer-for-keycard-info branch from 1aeb032 to f25d50f Compare January 29, 2025 09:10
@Parveshdhull
Copy link
Member Author

The E2E tests are not running automatically. @status-im/mobile-qa, could you please confirm if the PR is ok to merge?

@yevh-berdnyk
Copy link
Contributor

The E2E tests are not running automatically. @status-im/mobile-qa, could you please confirm if the PR is ok to merge?

Hi @Parveshdhull, I'll start the tests now and will let you know

@status-im-auto
Copy link
Member

50% of end-end tests have passed

Total executed tests: 8
Failed tests: 4
Expected to fail tests: 0
Passed tests: 4
Not executed tests: 2
IDs of not executed tests: 741554,741555 
IDs of failed tests: 727230,703133,740490,727229 

Not executed tests (2)

Click to expand
  • Rerun not executed tests
  • Failed tests (4)

    Click to expand
  • Rerun failed tests

  • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find `Button` by `xpath`: `//android.view.ViewGroup[contains(@content-desc,'Account 1')]`

    critical/test_wallet.py:174: in test_wallet_send_asset_from_drawer
        eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
    critical/test_wallet.py:43: in _get_balances_before_tx
        self.wallet_1.get_account_element().click()
    ../views/base_element.py:89: in click
        element = self.find_element()
    ../views/base_element.py:78: in find_element
        raise NoSuchElementException(
     Device 1: Button by xpath: `//android.view.ViewGroup[contains(@content-desc,'Account 1')]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    2. test_wallet_send_eth, id: 727229

    Device 1: Tap on found: Button
    Device 1: Find Button by xpath: //*[@content-desc='token-network']/android.widget.TextView[@text='Ether']

    critical/test_wallet.py:145: in test_wallet_send_eth
        self.wallet_1.send_asset(address='arb1:' + self.receiver['wallet_address'],
    ../views/wallet_view.py:167: in send_asset
        self.select_asset(asset_name)
    ../views/wallet_view.py:139: in select_asset
        xpath="//*[@content-desc='token-network']/android.widget.TextView[@text='%s']" % asset_name).click()
    ../views/base_element.py:89: in click
        element = self.find_element()
    ../views/base_element.py:78: in find_element
        raise NoSuchElementException(
     Device 1: Button by xpath: `//*[@content-desc='token-network']/android.widget.TextView[@text='Ether']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Class TestWalletOneDevice:

    1. test_wallet_balance_mainnet, id: 740490

    Device 1: Find Button by accessibility id: network-dropdown
    Device 1: Tap on found: Button

    critical/test_wallet.py:263: in test_wallet_balance_mainnet
        self.errors.verify_no_errors()
    base_test_case.py:179: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Device 1: For the Ether the wrong value 0.0062 is shown, expected 0.0052 in total
    E    Device 1: For the Status the wrong value 13.0 is shown, expected 10.0 in total
    E    Device 1: For the Ether the wrong value 0.0011 is shown, expected 0.0001 on Optimism
    E    Device 1: For the Status the wrong value 3.0 is shown, expected 0 on Optimism
    



    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133

    Device 1: Tap on found: Button
    # STEP: Check that removed user is not shown in the list anymore

    critical/chats/test_public_chat_browsing.py:246: in test_restore_multiaccount_with_waku_backup_remove_profile_switch
        self.errors.verify_no_errors()
    base_test_case.py:179: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Device 1: zQ3...dWXh5 was not restored as a contact from waku backup!
    E    Device 1: zQ3...Vacac was not restored as a contact from waku backup!
    E    Device 1: admin_open was not restored from waku-backup!!
    E    Device 1: member_open was not restored from waku-backup!!
    E    Device 1: admin_closed was not restored from waku-backup!!
    E    Device 1: member_closed was not restored from waku-backup!!
    



    Device sessions

    Passed tests (4)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    @yevh-berdnyk
    Copy link
    Contributor

    @Parveshdhull E2E failures are not related, PR can be merged, thanks!

    @Parveshdhull Parveshdhull merged commit dd26fcf into develop Jan 29, 2025
    5 of 6 checks passed
    @Parveshdhull Parveshdhull deleted the chore/documentation-drawer-for-keycard-info branch January 29, 2025 13:55
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Status: DONE
    Development

    Successfully merging this pull request may close these issues.

    Add Documentation drawer on Check your Keycard screen
    4 participants