Skip to content

Commit 8ebd6f7

Browse files
kgrytekgryte
committed
refactor: avoid assertion duplication and fix package meta data
Ref: 609682c Ref: #1356
1 parent 0a081ce commit 8ebd6f7

File tree

12 files changed

+57
-60
lines changed

12 files changed

+57
-60
lines changed

‎lib/node_modules/@stdlib/assert/is-negative-finite/README.md

+10-16
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ var isNegativeFinite = require( '@stdlib/assert/is-negative-finite' );
3232

3333
#### isNegativeFinite( value )
3434

35-
Tests if a `value` is a `number` having a finite negative value.
35+
Tests if a value is a number having a finite negative value.
3636

3737
<!-- eslint-disable no-new-wrappers -->
3838

@@ -54,13 +54,13 @@ bool = isNegativeFinite( 5.0 );
5454
bool = isNegativeFinite( null );
5555
// returns false
5656

57-
bool = isNegativeFinite( Number.NEGATIVE_INFINITY );
57+
bool = isNegativeFinite( -1.0/0.0 );
5858
// returns false
5959
```
6060

6161
#### isNegativeFinite.isPrimitive( value )
6262

63-
Tests if a `value` is a primitive `number` having a finite negative value.
63+
Tests if a value is a primitive number having a finite negative value.
6464

6565
<!-- eslint-disable no-new-wrappers -->
6666

@@ -76,7 +76,7 @@ bool = isNegativeFinite.isPrimitive( new Number( -3.0 ) );
7676

7777
#### isNegativeFinite.isObject( value )
7878

79-
Tests if a `value` is a `Number` object having a finite negative value.
79+
Tests if a value is a `Number` object having a finite negative value.
8080

8181
<!-- eslint-disable no-new-wrappers -->
8282

@@ -126,6 +126,12 @@ bool = isNegativeFinite( '-5' );
126126

127127
bool = isNegativeFinite( null );
128128
// returns false
129+
130+
bool = isNegativeFinite( -1.0/0.0 );
131+
// returns false
132+
133+
bool = isNegativeFinite( new Number( -1.0/0.0 ) );
134+
// returns false
129135
```
130136

131137
</section>
@@ -136,12 +142,6 @@ bool = isNegativeFinite( null );
136142

137143
<section class="related">
138144

139-
* * *
140-
141-
## See Also
142-
143-
- <span class="package-name">[`@stdlib/assert/is-number`][@stdlib/assert/is-number]</span><span class="delimiter">: </span><span class="description">test if a value is a number.</span>
144-
145145
</section>
146146

147147
<!-- /.related -->
@@ -150,12 +150,6 @@ bool = isNegativeFinite( null );
150150

151151
<section class="links">
152152

153-
<!-- <related-links> -->
154-
155-
[@stdlib/assert/is-number]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/assert/is-number
156-
157-
<!-- </related-links> -->
158-
159153
</section>
160154

161155
<!-- /.links -->

‎lib/node_modules/@stdlib/assert/is-negative-finite/benchmark/benchmark.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* limitations under the License.
1717
*/
1818

19-
/* eslint-disable no-undefined, no-empty-function */
19+
/* eslint-disable no-empty-function */
2020

2121
'use strict';
2222

@@ -43,12 +43,12 @@ bench( pkg+'::primitives', function benchmark( b ) {
4343
3.14,
4444
-5.0,
4545
-4.0,
46-
Number.NEGATIVE_INFINITY,
46+
-1.0/0.0,
4747
NaN,
4848
true,
4949
false,
5050
null,
51-
undefined
51+
void 0
5252
];
5353

5454
b.tic();
@@ -78,7 +78,7 @@ bench( pkg+'::objects', function benchmark( b ) {
7878
new Number( 2.0 ),
7979
new Number( -3.0 ),
8080
new Number( 3.14 ),
81-
new Number( Number.NEGATIVE_INFINITY )
81+
new Number( -1.0/0.0 )
8282
];
8383

8484
b.tic();
@@ -108,12 +108,12 @@ bench( pkg+'::primitives:isPrimitive', function benchmark( b ) {
108108
3.14,
109109
-5.0,
110110
-4.0,
111-
Number.NEGATIVE_INFINITY,
111+
-1.0/0.0,
112112
NaN,
113113
true,
114114
false,
115115
null,
116-
undefined
116+
void 0
117117
];
118118

119119
b.tic();
@@ -143,7 +143,7 @@ bench( pkg+'::objects:isPrimitive', function benchmark( b ) {
143143
new Number( 2.0 ),
144144
new Number( -3.0 ),
145145
new Number( 3.14 ),
146-
new Number( Number.NEGATIVE_INFINITY )
146+
new Number( -1.0/0.0 )
147147
];
148148

149149
b.tic();
@@ -173,12 +173,12 @@ bench( pkg+'::primitives:isObject', function benchmark( b ) {
173173
3.14,
174174
-5.0,
175175
-4.0,
176-
Number.NEGATIVE_INFINITY,
176+
-1.0/0.0,
177177
NaN,
178178
true,
179179
false,
180180
null,
181-
undefined
181+
void 0
182182
];
183183

184184
b.tic();
@@ -208,7 +208,7 @@ bench( pkg+'::objects:isObject', function benchmark( b ) {
208208
new Number( 2.0 ),
209209
new Number( -3.0 ),
210210
new Number( 3.14 ),
211-
new Number( Number.NEGATIVE_INFINITY )
211+
new Number( -1.0/0.0 )
212212
];
213213

214214
b.tic();

‎lib/node_modules/@stdlib/assert/is-negative-finite/docs/repl.txt

+9-9
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
Returns
1111
-------
1212
bool: boolean
13-
Boolean indicating whether value is a finite negative number.
13+
Boolean indicating whether a value is a finite negative number.
1414

1515
Examples
1616
--------
@@ -24,9 +24,9 @@
2424
false
2525
> bool = {{alias}}( null )
2626
false
27-
> bool = {{alias}}( Number.NEGATIVE_INFINITY )
27+
> bool = {{alias}}( -1.0/0.0 )
2828
false
29-
> bool = {{alias}}( new Number( Number.NEGATIVE_INFINITY ) )
29+
> bool = {{alias}}( new Number( -1.0/0.0 ) )
3030
false
3131

3232

@@ -41,7 +41,7 @@
4141
Returns
4242
-------
4343
bool: boolean
44-
Boolean indicating whether value is a number primitive having a finite
44+
Boolean indicating whether a value is a number primitive having a finite
4545
negative value.
4646

4747
Examples
@@ -50,9 +50,9 @@
5050
true
5151
> bool = {{alias}}.isPrimitive( new Number( -3.0 ) )
5252
false
53-
> var bool = {{alias}}.isPrimitive( Number.NEGATIVE_INFINITY )
53+
> var bool = {{alias}}.isPrimitive( -1.0/0.0 )
5454
false
55-
> bool = {{alias}}.isPrimitive( new Number( Number.NEGATIVE_INFINITY ) )
55+
> bool = {{alias}}.isPrimitive( new Number( -1.0/0.0 ) )
5656
false
5757

5858

@@ -67,7 +67,7 @@
6767
Returns
6868
-------
6969
bool: boolean
70-
Boolean indicating whether value is a number object having a finite
70+
Boolean indicating whether a value is a number object having a finite
7171
negative value.
7272

7373
Examples
@@ -76,9 +76,9 @@
7676
false
7777
> bool = {{alias}}.isObject( new Number( -3.0 ) )
7878
true
79-
> bool = {{alias}}.isObject( Number.NEGATIVE_INFINITY )
79+
> bool = {{alias}}.isObject( -1.0/0.0 )
8080
false
81-
> bool = {{alias}}.isObject( new Number( Number.NEGATIVE_INFINITY ) )
81+
> bool = {{alias}}.isObject( new Number( -1.0/0.0 ) )
8282
false
8383

8484
See Also

‎lib/node_modules/@stdlib/assert/is-negative-finite/docs/types/index.d.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ interface isNegativeFinite {
4949
* // returns false
5050
*
5151
* @example
52-
* var bool = isNegativeFinite( Number.NEGATIVE_INFINITY );
52+
* var bool = isNegativeFinite( -1.0/0.0 );
5353
* // returns false
5454
*/
5555
( value: number | Number ): value is number | Number;
@@ -74,7 +74,7 @@ interface isNegativeFinite {
7474
* Tests if a value is a number object having a negative value.
7575
*
7676
* @param value - value to test
77-
* @returns boolean indicating if a value is a number object having a negative value
77+
* @returns boolean indicating if a value is a number object having a finite negative value
7878
*
7979
* @example
8080
* var bool = isNegativeFinite.isObject( -3.0 );
@@ -91,7 +91,7 @@ interface isNegativeFinite {
9191
* Tests if a value is a negative number.
9292
*
9393
* @param value - value to test
94-
* @returns boolean indicating whether value is a negative number
94+
* @returns boolean indicating whether value is a finite negative number
9595
*
9696
* @example
9797
* var bool = isNegativeFinite( -5.0 );
@@ -122,11 +122,11 @@ interface isNegativeFinite {
122122
* // returns true
123123
*
124124
* @example
125-
* var bool = isNegativeFinite.isPrimitive( Number.NEGATIVE_INFINITY );
125+
* var bool = isNegativeFinite.isPrimitive( -1.0/0.0 );
126126
* // returns false
127127
*
128128
* @example
129-
* var bool = isNegativeFinite.isObject( new Number( Number.NEGATIVE_INFINITY ) );
129+
* var bool = isNegativeFinite.isObject( new Number( -1.0/0.0 ) );
130130
* // returns false
131131
*/
132132
declare var isNegativeFinite: isNegativeFinite;

‎lib/node_modules/@stdlib/assert/is-negative-finite/examples/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ console.log( isNegativeFinite( '-5' ) );
4242
console.log( isNegativeFinite( null ) );
4343
// => false
4444

45-
console.log( isNegativeFinite( Number.NEGATIVE_INFINITY ) );
45+
console.log( isNegativeFinite( -1.0/0.0 ) );
4646
// => false
4747

48-
console.log( isNegativeFinite( new Number(Number.NEGATIVE_INFINITY) ) );
48+
console.log( isNegativeFinite( new Number( -1.0/0.0 ) ) );
4949
// => false

‎lib/node_modules/@stdlib/assert/is-negative-finite/lib/index.js

+4-6
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
'use strict';
2020

2121
/**
22-
* Test if a value is a negative finite number.
22+
* Test if a value is a finite negative number.
2323
*
2424
* @module @stdlib/assert/is-negative-finite
2525
*
@@ -41,11 +41,10 @@
4141
* bool = isNegativeFinite( null );
4242
* // returns false
4343
*
44-
* bool = isNegativeFinite( Number.NEGATIVE_INFINITY );
44+
* bool = isNegativeFinite( -1.0/0.0 );
4545
* // returns false
4646
*
4747
* @example
48-
* // Use interface to check for finite negative number primitives...
4948
* var isNegativeFinite = require( '@stdlib/assert/is-negative-finite' ).isPrimitive;
5049
*
5150
* var bool = isNegativeFinite( -3.0 );
@@ -54,11 +53,10 @@
5453
* bool = isNegativeFinite( new Number( -3.0 ) );
5554
* // returns false
5655
*
57-
* bool = isNegativeFinite( new Number( Number.NEGATIVE_INFINITY ) );
56+
* bool = isNegativeFinite( new Number( -1.0/0.0 ) );
5857
* // returns false
5958
*
6059
* @example
61-
* // Use interface to check for negative number objects...
6260
* var isNegativeFinite = require( '@stdlib/assert/is-negative-finite' ).isObject;
6361
*
6462
* var bool = isNegativeFinite( -3.0 );
@@ -67,7 +65,7 @@
6765
* bool = isNegativeFinite( new Number( -3.0 ) );
6866
* // returns true
6967
*
70-
* bool = isNegativeFinite( new Number( Number.NEGATIVE_INFINITY ) );
68+
* bool = isNegativeFinite( new Number( -1.0/0.0 ) );
7169
* // returns false
7270
*/
7371

‎lib/node_modules/@stdlib/assert/is-negative-finite/lib/object.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var isNumber = require( '@stdlib/assert/is-number' ).isObject;
24-
var isFinite = require( '@stdlib/assert/is-finite' ).isObject; // eslint-disable-line stdlib/no-redeclare
24+
var NINF = require( '@stdlib/constants/float64/ninf' );
2525

2626

2727
// MAIN //
@@ -51,7 +51,8 @@ var isFinite = require( '@stdlib/assert/is-finite' ).isObject; // eslint-disable
5151
function isNegativeFinite( value ) {
5252
return (
5353
isNumber( value ) &&
54-
value.valueOf() < 0.0 && isFinite(value)
54+
value.valueOf() < 0.0 &&
55+
value.valueOf() > NINF
5556
);
5657
}
5758

‎lib/node_modules/@stdlib/assert/is-negative-finite/lib/primitive.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
// MODULES //
2222

2323
var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
24-
var isFinite = require( '@stdlib/assert/is-finite' ).isPrimitive; // eslint-disable-line stdlib/no-redeclare
24+
var NINF = require( '@stdlib/constants/float64/ninf' );
2525

2626

2727
// MAIN //
2828

2929
/**
30-
* Tests if a value is a number primitive having finite a negative value.
30+
* Tests if a value is a number primitive having a finite negative value.
3131
*
3232
* @param {*} value - value to test
3333
* @returns {boolean} boolean indicating if a value is a number primitive having a finite negative value
@@ -37,21 +37,22 @@ var isFinite = require( '@stdlib/assert/is-finite' ).isPrimitive; // eslint-disa
3737
* // returns true
3838
*
3939
* @example
40-
* var bool = isNegativeFinite( Number.NEGATIVE_INFINITY );
40+
* var bool = isNegativeFinite( -1.0/0.0 );
4141
* // returns false
4242
*
4343
* @example
4444
* var bool = isNegativeFinite( new Number( -3.0 ) );
4545
* // returns false
4646
*
4747
* @example
48-
* var bool = isNegativeFinite( new Number( Number.NEGATIVE_INFINITY ) );
48+
* var bool = isNegativeFinite( new Number( -1.0/0.0 ) );
4949
* // returns false
5050
*/
5151
function isNegativeFinite( value ) {
5252
return (
5353
isNumber( value ) &&
54-
value < 0.0 && isFinite(value)
54+
value < 0.0 &&
55+
value > NINF
5556
);
5657
}
5758

‎lib/node_modules/@stdlib/assert/is-negative-finite/package.json

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"name": "@stdlib/assert/is-negative-number",
2+
"name": "@stdlib/assert/is-negative-finite",
33
"version": "0.0.0",
4-
"description": "Test if a value is a number having a negative value.",
4+
"description": "Test if a value is a number having a finite negative value.",
55
"license": "Apache-2.0",
66
"author": {
77
"name": "The Stdlib Authors",
@@ -63,6 +63,8 @@
6363
"is",
6464
"isnumber",
6565
"isnumeric",
66+
"finite",
67+
"isfinite",
6668
"type",
6769
"check",
6870
"primitive",

0 commit comments

Comments
 (0)